Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing issues in header on tablet #970

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Fix spacing issues in header on tablet #970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17c472
Fix spacing issues in header on tablet
tunetheweb Jul 6, 2020
1607a99
Remove old px based margin as no longer required
tunetheweb Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/static/css/2019.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ h2.header {
text-decoration: none;
font-size: 16px;
font-size: 1rem;
margin-right: 40px;
}

.navigation-logo:hover,
Expand Down Expand Up @@ -585,7 +586,7 @@ header nav {
}

header nav > ul > li > * {
margin-right: 50px;
margin-right: 2vw;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives a slightly smaller or larger margin for larger viewports without having to introduce a new breakpoint.

Between 900px and 1200px it really needs to be 20px to avoid the two like ToC happening very early (<1120px) but that's a little squashed when we have more space on desktop so used vw units instead so there's a little more room to breath when we have the space.

I left the old 50px as a fallback but probably can remove that as vw support looks to be pretty comprehensive

}

header nav > ul > li:last-child > * {
Expand Down