Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font 2024 queries #3667

Closed
wants to merge 1 commit into from
Closed

Conversation

konfirmed
Copy link
Contributor

To be added

  • Font Usage
  • ...

@IvanUkhov
Copy link
Contributor

Oh, I have just stumbled upon this PR. I have I think this is obsolete due to #3696 and can be closed. The queries from 2022 have been updated to the new data format and reorganized according to the chapter's structure.

@tunetheweb tunetheweb mentioned this pull request Aug 14, 2024
@tunetheweb tunetheweb added the analysis Querying the dataset label Aug 21, 2024
@tunetheweb tunetheweb added this to the 2024 Analysis milestone Aug 21, 2024
@mgifford mgifford mentioned this pull request Aug 23, 2024
23 tasks
_TABLE_SUFFIX AS client,
COUNT(0) AS total_page
FROM
`httparchive.pages.2022_06_01_*`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using httparchive.all.pages and the date is still for 2022.

FROM
`httparchive.almanac.requests`
WHERE
date = '2022-06-01' AND
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 2022.

Copy link
Contributor

@mgifford mgifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting the obvious.

@mgifford
Copy link
Contributor

Sorry @IvanUkhov are the fonts being tracked elsewhere? The SQL definitely needs to be rewritten for the new format.

@IvanUkhov
Copy link
Contributor

IvanUkhov commented Aug 24, 2024

@mgifford, please consider the following PR to be the primary one: #3696. This PR here should be closed.

@konfirmed konfirmed closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Querying the dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants