-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add security chapter to 2022/zh-CN directory #3278
feat: add security chapter to 2022/zh-CN directory #3278
Conversation
Converting to draft for now until the actual translation is completed. |
Hi, @tunetheweb . Finished translation |
6f70bcd
to
95312f5
Compare
95312f5
to
2f44eab
Compare
…c.httparchive.org into zh-cn-2022-security-default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I've staged it here: https://20221126t153645-dot-webalmanac.uk.r.appspot.com/zh-CN/2022/security
@luckybai / @ibelem do you want to have a look at the actual translation?
Many thanks and great work, @Levix! The overall translation is in very high quality, it's hard to catch Chinese grammar issue and typos. I understand that there is no unified standard in the Chinese world for 柱状图/条形图, but the answers in multiple JS Chart frameworks and Q&A show that vertical columns to display data are usually called 柱状图, and horizontal columns to display data are more called 条形图。The two situations are reversed in several cases in your translation, please check if you can update them. https://www.highcharts.com.cn/docs/column-and-bar-charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tunetheweb I've completed the review of this round. Thanks!
Thanks @Levix , no more translation review comment on my side. @tunetheweb |
Thanks both - great collaboration! |
And it's live!: https://almanac.httparchive.org/zh-CN/2022/security |
Makes progress on #1067