Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add security chapter to 2022/zh-CN directory #3278

Merged
merged 16 commits into from
Nov 29, 2022

Conversation

Levix
Copy link
Member

@Levix Levix commented Nov 13, 2022

Makes progress on #1067

@tunetheweb tunetheweb marked this pull request as draft November 13, 2022 09:35
@tunetheweb tunetheweb added the translation world wide web label Nov 13, 2022
@tunetheweb
Copy link
Member

Converting to draft for now until the actual translation is completed.

@Levix
Copy link
Member Author

Levix commented Nov 26, 2022

Hi, @tunetheweb . Finished translation

@Levix Levix force-pushed the zh-cn-2022-security-default branch 2 times, most recently from 6f70bcd to 95312f5 Compare November 26, 2022 12:23
@Levix Levix force-pushed the zh-cn-2022-security-default branch from 95312f5 to 2f44eab Compare November 26, 2022 15:03
@tunetheweb tunetheweb marked this pull request as ready for review November 26, 2022 15:31
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've staged it here: https://20221126t153645-dot-webalmanac.uk.r.appspot.com/zh-CN/2022/security

@luckybai / @ibelem do you want to have a look at the actual translation?

src/config/2022.json Show resolved Hide resolved
@ibelem
Copy link
Member

ibelem commented Nov 28, 2022

Many thanks and great work, @Levix! The overall translation is in very high quality, it's hard to catch Chinese grammar issue and typos.

I understand that there is no unified standard in the Chinese world for 柱状图/条形图, but the answers in multiple JS Chart frameworks and Q&A show that vertical columns to display data are usually called 柱状图, and horizontal columns to display data are more called 条形图。The two situations are reversed in several cases in your translation, please check if you can update them.

https://www.highcharts.com.cn/docs/column-and-bar-charts
https://www.zhihu.com/question/56819190

Copy link
Member

@ibelem ibelem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tunetheweb I've completed the review of this round. Thanks!

src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
src/content/zh-CN/2022/security.md Outdated Show resolved Hide resolved
@ibelem
Copy link
Member

ibelem commented Nov 29, 2022

Thanks @Levix , no more translation review comment on my side. @tunetheweb

@tunetheweb
Copy link
Member

Thanks both - great collaboration!

@tunetheweb tunetheweb merged commit 23164f4 into HTTPArchive:main Nov 29, 2022
@tunetheweb
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation world wide web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants