Generate figure IDs #257
Merged
Generate figure IDs #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviscomi
requested changes
Oct 30, 2019
| @@ -336,7 +336,7 @@ <h2 id="adoption-of-http2">Adoption of HTTP/2</h2> | |||
| obscuresite.com are given equal weighting). There are lies, damn lies | |||
| and statistics. However, looking at other sources (for example the | |||
| <a | |||
| href="https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&measure=HTTP_RESPONSE_VERSION" | |||
| href="https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&measure=HTTP_RESPONSE_VERSION" | |||
There was a problem hiding this comment.
This change breaks the URL. Maybe if we change the & to ? this won't happen?
| @@ -192,7 +192,9 @@ <h2 id="the-state-of-performance">The state of performance</h2> | |||
| </p> | |||
| <p>So let's dive in and see what kind of insights we can find.</p> | |||
| <h3 id="fcp">FCP</h3> | |||
| <figure> | |||
| <figure | |||
| id="figure-1-distribution-of-websites-fast-average-and-slow-fcp-performance" | |||
There was a problem hiding this comment.
Honestly not a fan of these super long IDs. I think we can get by with the bare minimum of something simple like fig1 or figure-1. WDYT?
| @@ -728,7 +728,7 @@ <h3 id="internationalization">Internationalization</h3> | |||
| or not the different language versions properly link to each other. | |||
| However, from looking at the low adoption of | |||
| <a | |||
| href="https://www.google.com/url?q=https://support.google.com/webmasters/answer/189077?hl%3Den&sa=D&ust=1570627963630000&usg=AFQjCNFwzwglsbysT9au_I-7ZQkwa-QvrA" | |||
| href="https://www.google.com/url?q=https://support.google.com/webmasters/answer/189077?hl%3Den&sa=D&ust=1570627963630000&usg=AFQjCNFwzwglsbysT9au_I-7ZQkwa-QvrA" | |||
There was a problem hiding this comment.
Here we go again. Looks like the generator doesn't like &s even when they follow ? in URLs. Is this fixable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates the Figure IDs using the figcaption text on the ID. The ID's are a little long, and I'm open to suggestions to shorten them.
Progress on #199