Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest config.py #1605

Merged
merged 16 commits into from
Dec 1, 2020
Merged

Pytest config.py #1605

merged 16 commits into from
Dec 1, 2020

Conversation

AbbyTsai
Copy link
Contributor

@AbbyTsai AbbyTsai commented Dec 1, 2020

Pytest coverage for config.py. Makes progress on #1229

----------- coverage: platform win32, python 3.7.4-final-0 -----------
Name                            Stmts   Miss  Cover   Missing
-------------------------------------------------------------
server\__init__.py                 38     12    68%   19-21, 37-45
server\config.py                   69      0   100%
server\csp.py                       1      0   100%
server\errors.py                   18      8    56%   11, 16-17, 22, 27-28, 33-34
server\feature_policy.py            1      0   100%
server\helpers.py                 126      0   100%
server\language.py                 31      1    97%   10
server\routes.py                   59     30    49%   12, 18, 24-26, 32, 38-42, 48, 58-61, 78-82, 90-92, 98, 103, 109-112, 118
server\tests\__init__.py            0      0   100%
server\tests\config_test.py        25      2    92%   17-18
server\tests\helpers_test.py      183      0   100%
server\tests\validate_test.py      52      0   100%
server\validate.py                 78     33    58%   25-53, 59-72, 81-82, 104, 108-109
-------------------------------------------------------------
TOTAL                             681     86    87%
Required test coverage of 85% reached. Total coverage: 87.37%.

Note after discussion with @bazzadp we removed Gravatar support as not used and doesn't even work when we tested it!

@AbbyTsai AbbyTsai mentioned this pull request Dec 1, 2020
8 tasks
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good first attempt @AbbyTsai !

I've suggested some improvements

src/server/tests/config_test.py Outdated Show resolved Hide resolved
src/server/tests/config_test.py Outdated Show resolved Hide resolved
src/server/tests/config_test.py Outdated Show resolved Hide resolved
src/server/tests/config_test.py Outdated Show resolved Hide resolved
src/server/tests/config_test.py Show resolved Hide resolved
src/server/tests/config_test.py Outdated Show resolved Hide resolved
src/server/tests/config_test.py Show resolved Hide resolved
src/server/tests/config_test.py Outdated Show resolved Hide resolved
@tunetheweb tunetheweb added this to the 2020 Backlog milestone Dec 1, 2020
@tunetheweb tunetheweb added the development Building the Almanac tech stack label Dec 1, 2020
@tunetheweb tunetheweb merged commit 34ea8ea into main Dec 1, 2020
@tunetheweb tunetheweb deleted the pytest-configpy branch December 1, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants