Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language redirects #1523

Merged
merged 10 commits into from
Nov 18, 2020
Merged

Support language redirects #1523

merged 10 commits into from
Nov 18, 2020

Conversation

tunetheweb
Copy link
Member

Support language redirects in our URLs so if you try /en-GB/ it redirects to /en/

This also allows support of different Chinese Dialects (including plain old zn which redirects to simplified Chinese - zh-CN same as MDN does).

It also allows us to move a language like we need to resolve #1516

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Nov 15, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Nov 15, 2020
@tunetheweb tunetheweb requested a review from a team November 18, 2020 13:40
src/server/language.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tunetheweb tunetheweb merged commit e19673d into main Nov 18, 2020
@tunetheweb tunetheweb deleted the support_language_redirects branch November 18, 2020 20:15
@tunetheweb tunetheweb mentioned this pull request Dec 28, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language code for Traditional Chinese
2 participants