Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiceover percentiles for English chapters #1256

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Conversation

tunetheweb
Copy link
Member

Makes progress on #1254

Note this adds another heading to the CDN tables:

Old:
Percentile's marked p10 - p90

New:
Percentile's marked 10 - 90 with a percentile heading

@tunetheweb tunetheweb added writing Related to wording and content accessibility Accessibility related labels Aug 25, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Aug 25, 2020
@rviscomi
Copy link
Member

By separating the "percentile" text from the numbers, is this any clearer to assistive technology users? 🤔

@tunetheweb
Copy link
Member Author

By separating the "percentile" text from the numbers, is this any clearer to assistive technology users? 🤔

In so much as any large table is clear if just listening to it! But it does stop reading as "Page X" so that's a plus 😁

We already use this in other chapters like the compression chapter

@tunetheweb
Copy link
Member Author

tunetheweb commented Aug 28, 2020

By separating the "percentile" text from the numbers, is this any clearer to assistive technology users? 🤔

Oops - looks like I never actually add the note on testing for this that I did!

On VoiceOver it's not as nice when you go into the cells as it only announces the colgroup heading

Old: "Page 10 1, Page 25 1, Page 50 1, Page 75 1, Page 90 2"
New "Percentile 1, 1, 1, 1, 2"

So voiceover doesn't announce sub headers and only announces the colgroup heading when first going into that (column 1). Ideally it should announce "Percentile 10 1, Percentile 25 1..." though on other hand that could also be repetitive and annoying. Perhaps better would be "Percentile 10 1, 25 1..." thought in this example that's actually quite confusing. Maybe what it currently does is actually the best way 😀

Either way, that seems like a VoiceOver bug and I still think this change is better than what it announces currently as removes the incorrect "Page".

@tunetheweb
Copy link
Member Author

Updated to better implementation after discussion on the A11Y slack.

I still think using the p10 - p90 headings in tables should be discouraged in future as not everyone will be familiar what they mean, and we can't add a "Percentile" colgroup without removing the individual column headings from being read in VoiceOver (and maybe other ATs too).

However this change solves the immediate problem of VoiceOver reading this out wrong so think this is good to merge now.

@tunetheweb tunetheweb merged commit d21770f into main Sep 1, 2020
@tunetheweb tunetheweb deleted the voiceover_percentiles_en branch September 1, 2020 19:44
sudheendrachari pushed a commit that referenced this pull request Sep 15, 2020
* Update percentile wording

* Add colgroup scope

* Better wway of handling percentile headers

* Missed one
rviscomi added a commit that referenced this pull request Sep 16, 2020
* Fixes

Intent: Redesign of year and language switcher

Major Changes:
- Introduce two new macros 'styled_lang_dropdown' and 'styled_year_dropdown'
- Existing DOM structure is retained and logic to generate those have been moved into
'native_year_dropdown' and 'native_lang_dropdown'
- Existing select-and-option structure will be used for mobile view where native dropdown picker of the
OS will be used

UI/UX details:
- The button which triggers dropdown will look attached to the dropdown that comes up
- Dropdown list will be aligned to the left edge of button if the entire dropdown content can fit into the
viewport
- Else, Right edge of Dropdown list will be aligned to the right edge of button
- Chevron in the button  will animate to a check mark when the list is opened
- On hover of the items in dropdown menu, its background color and font color will change

Testing:
- Manually verified the behaviour of both the switchers
- Verified that options are keyboard focusable (Once menu is open the list items are Tab-able,
clicking Tab on last option navigates out of the list to the next focusable element)
- Verified that options are reachable via screen reader also

* fixed stylelint errors

* Address review comments

* fix lint errors

* Address review comments

* adding lang for anchor

* css lint error fix

* Portuguese translation of base template (#1215)

* Translate-pt contributors.html

* Translate-pt error.html

* Update error.html

* Update src/templates/pt/2019/error.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/pt/2019/error.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/pt/2019/contributors.html

Co-authored-by: Barry Pollard <[email protected]>

* Portuguese translation of base template 2020

* Portuguese translation of base template

* Portuguese translation of base template

* Portuguese translation of base template

* Update src/templates/pt/2019/error.html

Co-authored-by: Barry Pollard <[email protected]>

Co-authored-by: Barry Pollard <[email protected]>

* Generate Chapters (#1220)

Co-authored-by: bazzadp <[email protected]>

* Bump ejs from 3.1.3 to 3.1.5 in /src (#1225)

Bumps [ejs](https://github.com/mde/ejs) from 3.1.3 to 3.1.5.
- [Release notes](https://github.com/mde/ejs/releases)
- [Changelog](https://github.com/mde/ejs/blob/master/CHANGELOG.md)
- [Commits](mde/ejs@v3.1.3...v3.1.5)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix lighthouse errors (#1216)

* Generate Chapters (#1226)

Co-authored-by: bazzadp <[email protected]>

* Remove flex grow to top align these (#1231)

* Lint the ultimate HTML generated for the site (#1235)

* Lint generated HTML

* Freeze Linter version

* Correct Linter command

* Fix linter version

* Fix cleanup

* Code cleanup

* Change to new node version syntax

* Track changes between releases (#1238)

* Chinese translation of Performance chapter + some clean ups of previous translations. (#1227)

* 1st test

* Chinese translation

* accessibility and base

* ZH translation

* non-chapters HTML template files update

* update templates

* Chinese translate

* Makes progress on #1067

* Makes progress on #1067

* delete space

* debug markdown hardtab

* Update src/templates/zh/2020/contributors.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh/2019/accessibility_statement.html

Co-authored-by: AbbyTsai <[email protected]>

* Update src/templates/zh/2019/methodology.html

Co-authored-by: AbbyTsai <[email protected]>

* update json

* update folder name cn-simp

* updated to zh_CN

* add zh_CN

* Update src/config/2020.json

Co-authored-by: Barry Pollard <[email protected]>

* Update src/language.py

Co-authored-by: Barry Pollard <[email protected]>

* Update src/config/2019.json

Co-authored-by: Barry Pollard <[email protected]>

* Update base.html

* folder name zh-CN

* updated json profile and base.html bio translation

* fixed #1073 @bazzadp and @AbbyTsai's review

* Update src/templates/zh-CN/2019/base.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/base.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/base.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/config/2020.json

Co-authored-by: Barry Pollard <[email protected]>

* Update src/config/2020.json

Co-authored-by: Barry Pollard <[email protected]>

* Update src/config/2020.json

Co-authored-by: Barry Pollard <[email protected]>

* fix featured_chapters.html and index

* fix 2020 index

* Update src/templates/zh-CN/2019/base.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/contributors.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2020/contributors.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/base_ebook.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/config/2019.json

* Update src/config/2019.json

* Update src/config/2019.json

* Update src/templates/zh-CN/2019/methodology.html

* Update src/templates/zh-CN/2019/methodology.html

* update featured_chapters.html

* fix 2 issues

- Methodology tables headings (lines 177 - 129, 184 - 186, 190, 200, 212, 218, 265, 266, 271, 275, 279, - should it be translated?
- Base.html (line 1240) - "Generated with PrinceXML"

* accessibility translate and bugs fix

* bug fix

* Update table_of_contents.html

* word error fix

* fix accessibility.md

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* add back this deleted line so the line numbers stay in sync with English version

* delete tabs

* delete white spaces

* fix error

* fix links format caused by editor tool

* grammar fix

* first line updated

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/methodology.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/table_of_contents.html

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/accessibility.md

Co-authored-by: Barry Pollard <[email protected]>

* change en to cn links,delete white spaces,check commas

* search and delete white spaces

* comma deleted

* performance chapter

* 1 word change

* Update src/content/zh-CN/2019/performance.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/performance.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/performance.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/content/zh-CN/2019/performance.md

Co-authored-by: Barry Pollard <[email protected]>

* Update src/templates/zh-CN/2019/featured_chapters.html

Co-authored-by: Barry Pollard <[email protected]>

Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: AbbyTsai <[email protected]>

* Generate Chapters (#1239)

Co-authored-by: bazzadp <[email protected]>

* French Translation - JavaScript Chapter (#1218)

* French translation - JavaScript Chapter

Makes progress on #539

* Update src/content/fr/2019/javascript.md

Co-authored-by: Barry Pollard <[email protected]>

* Add translation to featured_chapters

* Fix typo numbers

* Fixes from @nico3333fr 's feedback

Co-authored-by: Barry Pollard <[email protected]>

* Config updates for new chapters and other misc cleanups (#1232)

* Config updates for new chapters and other misc cleanups

* Update src/templates/fr/2019/base.html

Co-authored-by: Boris Schapira <[email protected]>

* Change JAMstack to Jamstack

* Remove regions

* Add Simplified Chinese to README

Co-authored-by: Boris Schapira <[email protected]>

* Generate Chapters (#1240)

Co-authored-by: bazzadp <[email protected]>

* Generate Chapters (#1241)

Co-authored-by: bazzadp <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>

* Translating 2019 Fonts chapter to Spanish (#1234)

* Translating Fonts chapter to Spanish

* Fixing markdown lint errors in 2019 Fonts Spanish translation.

* Translating the featured chapter information to Spanish. Changing Performance to Rendimiento. Translating zachleat bio.

* Generate Chapters (#1242)

Co-authored-by: bazzadp <[email protected]>

* French Translation - All 2019 Authors (#1217)

* fr - all authors

* Fix markup issues

* Generate Ebooks (#1243)

Co-authored-by: bazzadp <[email protected]>

* Bump github/super-linter from v3.7.0 to V3.8.0 (#1244)

Bumps [github/super-linter](https://github.com/github/super-linter) from v3.7.0 to V3.8.0.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@v3.7.0...ef99a48)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/github-script from v2.0.1 to v3 (#1245)

Bumps [actions/github-script](https://github.com/actions/github-script) from v2.0.1 to v3.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v2.0.1...626af12)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Set explicitly GitHub Actions versions were not set (#1246)

* Set explicitly GitHub Actions versions where not set

* Remove incorrect version strategy

* Bump github/super-linter from V3.8.0 to v3.8.3 (#1251)

Bumps [github/super-linter](https://github.com/github/super-linter) from V3.8.0 to v3.8.3.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@V3.8.0...9f2c656)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump prettier from 2.0.5 to 2.1.0 in /src (#1250)

Bumps [prettier](https://github.com/prettier/prettier) from 2.0.5 to 2.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/prettier@2.0.5...2.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Generate Chapters (#1252)

Co-authored-by: bazzadp <[email protected]>

* Fix percentiles in FR translation of JavaScript chapter (#1249)

Using Voice Over, I noticed that using 'p25' is, in fact, read as 'page 25'.

* Generate Chapters (#1255)

Co-authored-by: bazzadp <[email protected]>

* Display Ebook download size on link (#1253)

* Add size to Ebooks download link

* Calc book size dynamically

* Add explanation comment

* Simplify calc

* Review Feedback

* Linting fixes

* Remove generated content from being tracked in Git (#1230)

* Remove generated content

* Add deploy script

* Linting fixes

* Linting and README fixes

* Linting fixes

* Check branch is clean before deploying

* Uncapitalise non-default

* Linting fixes

* Improved deploy method

* Add PDFs back in

* Linting issues

* Uncomment commands

* Increment patch instead of major by default

* Fix typo

* Review feedback and other cleanups

* Fix typo

* Update src/tools/scripts/deploy.sh

Co-authored-by: Sawood Alam <[email protected]>

* Update src/tools/scripts/deploy.sh

Co-authored-by: Sawood Alam <[email protected]>

* Update src/tools/scripts/deploy.sh

Co-authored-by: Sawood Alam <[email protected]>

* Review feedback

* Update src/.gcloudignore

Co-authored-by: Rick Viscomi <[email protected]>

* README updates

* Make deploy.zip smaller

* Cleanup

Co-authored-by: Sawood Alam <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>

* Bump prettier from 2.1.0 to 2.1.1 in /src (#1257)

Bumps [prettier](https://github.com/prettier/prettier) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/prettier@2.1.0...2.1.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump peter-evans/create-pull-request from v3.1.2 to v3.2.0 (#1260)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from v3.1.2 to v3.2.0.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v3.1.2...9bf4b30)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* SQL utilities for the BigQuery dataset (#1259)

* sql utils

* parsed_css queries

* third parties

* Voiceover percentiles for English chapters (#1256)

* Update percentile wording

* Add colgroup scope

* Better wway of handling percentile headers

* Missed one

* Generate Chapters (#1263)

Co-authored-by: bazzadp <[email protected]>

* fix empty image formats (#1262)

* Bump github/super-linter from v3.8.3 to v3.9.2 (#1267)

Bumps [github/super-linter](https://github.com/github/super-linter) from v3.8.3 to v3.9.2.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@v3.8.3...7d53a77)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github/super-linter from v3.9.2 to v3.9.3 (#1268)

Bumps [github/super-linter](https://github.com/github/super-linter) from v3.9.2 to v3.9.3.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@v3.9.2...eb0d0ed)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Stop having comma for two person lists (#1266)

* Bump github/super-linter from v3.9.3 to v3.9.4 (#1269)

Bumps [github/super-linter](https://github.com/github/super-linter) from v3.9.3 to v3.9.4.
- [Release notes](https://github.com/github/super-linter/releases)
- [Commits](github/super-linter@v3.9.3...e89faa7)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* GitHub Action to test generated template changes (#1271)

* GitHub Action to test generated template changes

* Fix repo name

* Update .github/workflows/test-template-changes.yml

Co-authored-by: Sawood Alam <[email protected]>

* Update .github/workflows/test-template-changes.yml

Co-authored-by: Sawood Alam <[email protected]>

* Review feedback

Co-authored-by: Sawood Alam <[email protected]>

* Avoid using p10 - p90 in Japanese chapters for accessibility reasons (#1265)

* Generate Chapters (#1272)

Co-authored-by: bazzadp <[email protected]>

* Avoid using p10 - p90 (#1264)

* Generate Chapters (#1273)

Co-authored-by: bazzadp <[email protected]>

* Generate Ebooks (#1274)

Co-authored-by: bazzadp <[email protected]>

* Fix version numbering deploy script (#1275)

* Fix version numbering issue

* Alternative approach to pass linting

* Fix linting errors

* Lint all files on Super Linter upgrade (#1276)

* Lint all files on Super Linter upgrade

* Fix version

* Few small perf fixes for home page (#1277)

* Few small perf fixes for home page

* Optimised images with calibre/image-actions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Generate Chapters (#1278)

Co-authored-by: bazzadp <[email protected]>

* Bump node-fetch from 2.6.0 to 2.6.1 in /src (#1279)

Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump peter-evans/create-pull-request from v3.2.0 to v3.3.0 (#1280)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from v3.2.0 to v3.3.0.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v3.2.0...44f76dd)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* CMS 2020 queries (#1087)

* CMS 2020

* WIP: Start on the 2020 CMS Queries

* update to 2020-08-01

* Core Web Vitals by CMS

* CWV distribution

* Lighthouse

* add results sheet URL to README

* new query for CMS adoption YoY without client breakdown

* Update from 2019 to 2020

Co-authored-by: Artem Denysov <[email protected]>

Co-authored-by: Greg Brimble <[email protected]>
Co-authored-by: Artem Denysov <[email protected]>

* Update requests.sql (#1285)

* Update summary_response_bodies.sql (#1286)

* Workaround linting error (#1287)

* Tidy up 2019 sql (#1288)

* COUNT(0) and newlines

* Add date columns to dated Almanac tables

* pwa candidates (#1289)

* Bump pytest from 6.0.1 to 6.0.2 in /src (#1290)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@6.0.1...6.0.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* PWA table utils (#1291)

* pwa candidates

* pwa candidates

* pwa helpers

* pwa readme

* border color changed to yellow

* duplicate id fix

* Revert "Portuguese translation of base template (#1215)"

This reverts commit b99abef.

* border color changed to yellow

* duplicate id fix

* arrow up listener for footer list

Co-authored-by: William Sandres <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bazzadp <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cheng Xi <[email protected]>
Co-authored-by: AbbyTsai <[email protected]>
Co-authored-by: Boris Schapira <[email protected]>
Co-authored-by: Carlos Torres <[email protected]>
Co-authored-by: Sawood Alam <[email protected]>
Co-authored-by: Rick Viscomi <[email protected]>
Co-authored-by: Greg Brimble <[email protected]>
Co-authored-by: Artem Denysov <[email protected]>
Co-authored-by: Barry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility related writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants