Chinese translation of Accessibility chapters and templates bugs fix

[chengxicn]

Makes progress on #1067

[tunetheweb]

One more request. Could you change the first line of featured_chapters.html from this:

{%- set featured_chapter = ("accessibility","caching","cdn","cms","compression","css","ecommerce","fonts","http2","javascript","markup","media","mobile-web","page-weight","performance","pwa","resource-hints","security","seo","third-parties") | random %}

to this?:

{%- set featured_chapter = ("accessibility","accessibility") | random %}
{#
  Below is the full set of chapters. If all are translated then replace above line with this one.
  Until then, add chapters to above first line as they are translated (min of two chapters so repeat if only one chapter)
  {%- set featured_chapter = ("accessibility","caching","cdn","cms","compression","css","ecommerce","fonts","http2","javascript","markup","media","mobile-web","page-weight","performance","pwa","resource-hints","security","seo","third-parties") | random %}
#}

This will mean only the translated Accessibility chapter will show as a random featured chapter on the hope page - no point in showing a featured chapter that isn't fully translated yet as that will only disappoint those that click on it! We can add to this list as you translate more chapters. Note also the random function requires at least two in the list hence why we repeat accessibility twice for now.

Let me know when good for me to re-review!

[chengxicn]

One more request. Could you change the first line of featured_chapters.html from this:

{%- set featured_chapter = ("accessibility","caching","cdn","cms","compression","css","ecommerce","fonts","http2","javascript","markup","media","mobile-web","page-weight","performance","pwa","resource-hints","security","seo","third-parties") | random %}

to this?:

{%- set featured_chapter = ("accessibility","accessibility") | random %}
{#
  Below is the full set of chapters. If all are translated then replace above line with this one.
  Until then, add chapters to above first line as they are translated (min of two chapters so repeat if only one chapter)
  {%- set featured_chapter = ("accessibility","caching","cdn","cms","compression","css","ecommerce","fonts","http2","javascript","markup","media","mobile-web","page-weight","performance","pwa","resource-hints","security","seo","third-parties") | random %}
#}

This will mean only the translated Accessibility chapter will show as a random featured chapter on the hope page - no point in showing a featured chapter that isn't fully translated yet as that will only disappoint those that click on it! We can add to this list as you translate more chapters. Note also the random function requires at least two in the list hence why we repeat accessibility twice for now.

Let me know when good for me to re-review!

First line updated, thanks for reviewing!

[tunetheweb]

Ready for me to re-review? Or still changing things?

[chengxicn]

Ready for me to re-review? Or still changing things?

Sorry, OK now,won't change in this PR, please review. I'll create a new branch next time to reduce noise.

[tunetheweb]

Spotted a few more things!

[chengxicn]

I'm checking on all the CN links, it will take a while.

[chengxicn]

done, searched and deleted spaces, links updated, but Chinese commas are a little different from English ,so didn't commit the suggestions.

[tunetheweb]

Looks great - thanks so much for working through all the feedback!

Just one more small question.

@limhenry do you have time to check the actual translation now I'm happy with the technicalities?

[tunetheweb]

I’ve merged this as planning on doing a release. @limhenry if you get a chance to review later and spot anything than can you open another pull request to correct?

[limhenry]

@chengxicn is it better to use "：" instead of ":" ?