Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better language code for Simplified Chinese #1116

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 28, 2020

Currently the language code is converted to Python class references which cannot have underscores.

To allow that to work, at present we have the zh_CN code, which follows the convention of lowercase language used for other languages, but then doesn't follow ISO convention of using hyphen instead underscore so a weird hybrid.

Let's fix it!

Progress on #1073

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jul 28, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Jul 28, 2020
Copy link
Collaborator

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunetheweb tunetheweb merged commit 9e73b19 into main Jul 29, 2020
@tunetheweb tunetheweb deleted the better_lang_codes branch July 29, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants