Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance 2020 queries #1091
Performance 2020 queries #1091
Changes from 28 commits
8dd8a92
8892bb1
5ec7860
8e94984
a67e276
b111b5a
38580fa
7d007b7
aff681b
61a1093
4e61180
d46e1b5
83235de
8e13885
32e6a42
d80737b
a5cf826
078c503
605154e
acc0b86
41c760c
d4ce1af
6f683e4
818ab01
1ae70c0
0ecea02
f52241f
aeb4f15
5b0f2f9
05b2ce2
62035e7
0b46b3e
c18af83
9f5529a
e1880d1
706e358
2df9022
b84733d
b6c5aef
4f6598a
b91ce5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my earlier comment about using the
blink_features
table instead ofresponse_bodies
, which is extremely expensive to query.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is supposed to be a timeseries.
Also, and I hate to complicate things, but we should only use the September dataset for LH performance metrics. The August dataset is the canonical one for the 2020 Web Almanac, off of which all chapters will be based. So for queries like this, we should use the August data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
202009 doesn't exist yet, so this query returns 0 results. For consistency please use 202008 (August)