Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance 2020 #905

Closed
10 tasks done
foxdavidj opened this issue Jun 27, 2020 · 77 comments
Closed
10 tasks done

Performance 2020 #905

foxdavidj opened this issue Jun 27, 2020 · 77 comments
Assignees
Labels
2020 chapter Tracking issue for a 2020 chapter writing Related to wording and content

Comments

@foxdavidj
Copy link
Contributor

foxdavidj commented Jun 27, 2020

Part II Chapter 9: Performance

Content team

Authors Reviewers Analysts Draft Queries Results
@thefoxis @dimension85 @borisschapira @estelle @zeman @rviscomi @OBTo @noamr @ashrith-kulai @Zizzamia @exterkamp @max-ostapenko @dooman87 Doc *.sql Sheet

Content team lead: @thefoxis

Welcome chapter contributors! You'll be using this issue throughout the chapter lifecycle to coordinate on the content planning, analysis, and writing stages.

The content team is made up of the following contributors:

New contributors: If you're interested in joining the content team for this chapter, just leave a comment below and the content team lead will loop you in.

Note: To ensure that you get notifications when tagged, you must be "watching" this repository.

Milestones

0. Form the content team

  • Jul 6th: Project owners have selected an author to be the content team lead
  • Jul 13th: The content team has at least one author, reviewer, and analyst (minimally viable team formed)

1. Plan content

  • Jul 20th: The content team has completed the chapter outline in the draft doc
  • Jul 27th: Analysts have triaged the feasibility of all proposed metrics

2. Gather data

  • Aug 1 - 31: August crawl
  • Sep 7th: Analysts have queried all metrics and saved the output to the results sheet

3. Validate results

4. Draft content

  • Nov 12th: Authors have completed the first draft in the doc
  • Nov 26th: The content team has prototyped all data visualizations

5. Publication

  • Nov 26th: The content team has reviewed the final draft, converted to markdown, and filed a PR to add it to the 2020 content directory
  • Dec 9th: Target launch date
@foxdavidj foxdavidj added help wanted Extra attention is needed analysis Querying the dataset writing Related to wording and content labels Jun 27, 2020
@foxdavidj foxdavidj added this to the 2020 Content Planning milestone Jun 27, 2020
@dimension85
Copy link

I am interested in the reviewers role for this topic - Phil

@borisschapira borisschapira pinned this issue Jun 27, 2020
@borisschapira borisschapira unpinned this issue Jun 27, 2020
@borisschapira
Copy link
Contributor

I'm afraid I'm not fluent enough in English to create the content. I can help reviewing, though.

@rviscomi rviscomi added the 2020 chapter Tracking issue for a 2020 chapter label Jun 27, 2020
@rviscomi
Copy link
Member

rviscomi commented Jul 1, 2020

@thefoxis thank you for agreeing to be the lead author for the Performance chapter! As the lead, you'll be responsible for driving the content planning and writing phases in collaboration with your content team, which will consist of yourself as lead, any coauthors you choose as needed, peer reviewers, and data analysts.

The immediate next steps for this chapter are:

  1. Establish the rest of your content team. Several other people were interested or nominated (see below), so that's a great place to start. The larger the scope of the chapter, the more people you'll want to have on board.
  2. Start sketching out ideas in your draft doc.
  3. Catch up on last year's chapter and the project methodology to get a sense for what's possible.

There's a ton of info in the top comment, so check that out and feel free to ping myself or @OBTo with any questions!

To everyone else who has been nominated:

@logicalphase
@Zizzamia
@noamr
@dimension85

we'd still love to have you contribute as a peer reviewer or coauthor as needed. Let us know if you're still interested!

@rviscomi
Copy link
Member

rviscomi commented Jul 1, 2020

@dimension85 @borisschapira thank you! I've added you both as reviewers.

@estelle
Copy link
Member

estelle commented Jul 1, 2020

I can also help out.

@rviscomi
Copy link
Member

rviscomi commented Jul 1, 2020

Thanks Estelle! I've also added you as a reviewer.

@dimension85
Copy link

Excellent, thanks for adding me to the team - this is the first time I have been involved with this project and am looking forward to contributing.

@logicalphase
Copy link
Contributor

Would love to co-author this section. Please let me know if I can help.

@rviscomi rviscomi added help wanted: reviewers This chapter is looking for reviewers help wanted: analysts This chapter is looking for data analysts and removed help wanted Extra attention is needed labels Jul 2, 2020
@zeman
Copy link

zeman commented Jul 2, 2020

Happy to review again this year!

@foxdavidj
Copy link
Contributor Author

An all-star team again this year. Really excited for this 🎉

@noamr
Copy link

noamr commented Jul 2, 2020 via email

@ashrith-kulai
Copy link

I would like to be a reviewer for this topic.

@Zizzamia
Copy link
Contributor

Zizzamia commented Jul 2, 2020

Happy to join as a reviewer, looking forward to collaborate with the all Content team. 🌲 🚀 🌕

@rviscomi rviscomi removed the help wanted: reviewers This chapter is looking for reviewers label Jul 2, 2020
@thefoxis
Copy link
Contributor

thefoxis commented Jul 2, 2020

👋 hi everyone!

thanks again @rviscomi and @OBTo for selecting me to lead this effort. looks like we have a solid team of reviewers but we're short on analysts. should we be looking for people swapping areas of responsibility or look for new people to join?

I'm going to re-read last years chapter and reflect on what has happened in perf within the year. I think it'd be nice to speak to some new developments in the space, for example core web vitals or the shift in performance score algorithm. but it also depends on what sort of trends/data we're able to discover via the archive. I'll jot some notes down in the google doc within the next couple days. JavaScript is also always good to cover since it affects perf/UX greatly, so we could be looking at TBT & TTI. none of these were really covered last year so there would be no duplication (the previous report mentioned FID though, which is only relevant to people using RUM solutions/not Lighthouse).

if anyone has any ideas/suggestions, I'm all 👂

@Zizzamia
Copy link
Contributor

Zizzamia commented Jul 2, 2020

@thefoxis yeah I agree 100% ! 🔥

Other points on top of my mind are:

What else? 🤔
One thing I am kind of curious to reflect is the different implications of TBT and LCP performance between SPA and SSR, and how websites are handling those performance trade-offs.

That's it for now, but I am sure the rest of the team has more angles we could deep dive 🌲🚀🌕

@thefoxis
Copy link
Contributor

@OBTo thank you for letting me know! I didn't see it. I doubt I can do this by Nov 9, I've been sick for the past week and still I am not well (fortunately, it's not covid 🤪 ) so it delays my ability to write a bit. that being said, I shouldn't need a lot of time to produce a draft, I'll post here once it's ready 👍

@rviscomi
Copy link
Member

Sounds great, hope you feel better!

@max-ostapenko
Copy link
Contributor

@thefoxis get well soon!
We are looking forward to receiving your feedback again.

@thefoxis
Copy link
Contributor

@OBTo @rviscomi I'll have a complete draft ready sometime next week. there's a bit more to be written than I initially expected. of course, you can keep an eye on the draft in the doc, as I'm writing directly there.

@max-ostapenko @dooman87 I'd appreciate some help with the charts, since some are only representing a single metric versus complete readings and my spreadsheet skills turn out to fall a bit short here 😅 I'm going off the 2019 almanac, so the charts for each metric are:

  • metric by device
  • metric by geo
  • metric by effective connection type

The connection type chart wasn't portraying quite what I wanted (as per 2019 chapter), I tried playing with it, but didn't go far. This is what I'd love to have for each metric:

Screen Shot 2020-11-11 at 1 19 45 pm

I'm not entirely sure how to generate the charts for geo + device for other metrics than LCP so if you could point me in the right direction or help out here, that'd be great 😸

@rviscomi
Copy link
Member

Hi @thefoxis I'm excited to see this coming along! I'm also happy to help with the data viz, feel free to @ me on whichever charts you'd like help with.

@max-ostapenko
Copy link
Contributor

max-ostapenko commented Nov 13, 2020

@thefoxis As per your question: please check the chart here, if I understood you correctly: https://docs.google.com/spreadsheets/d/164FVuCQ7gPhTWUXJl1av5_hBxjncNi0TK8RnNseNPJQ/edit#gid=306222260
(I changed columns to the corresponding ones in a data range)

I'll appreciate if we can jump to sheet comments for exported results discussion. Please add comments on what needs adjustments and if any visualisations are missing.

@thefoxis
Copy link
Contributor

@rviscomi can you point me to the CrUX's categorisations of good|needs improvement|poor? I know where those ranges live for LH/perf score calculation but I'm not quite sure if it's identical in CrUX's dataset 🤔 I just want to be able to reference it for each metric since you can't tell from the charts.

@rviscomi
Copy link
Member

rviscomi commented Nov 20, 2020

@thefoxis the thresholds used by CrUX for the CWV are defined at https://web.dev/vitals/#core-web-vitals

We could also edit the legends of the charts to say something like "Good (<100ms)" and "Poor (>=300ms)".

@thefoxis
Copy link
Contributor

@rviscomi gotcha! that's exactly what I had in mind :) what about FCP and TTFB values? where do those come from?

FYI I only have the geo sections (pending charts) + conclusion left, so if you want to read the draft as is and leave comments, you're more than welcome to! cc @OBTo

@rviscomi
Copy link
Member

FCP and TTFB are more subjective and don't have official documentation. For reference the thresholds used by CrUX for fast/slow are:

FCP: 1.5s, 2.5s
TTFB: 0.5s, 1.5s

@borisschapira
Copy link
Contributor

A quick word to say that I'm starting the review and posting comments on the doc.
I am French 🇫🇷 , and our culture teaches us to be quite direct. So I'll try to formulate things in a way that is appropriate, but I may not do it well. But I don’t mean to be rude. Even if I comment some things as food for thoughts, it's only out of constructive criticism. Because I find that the work that has been done in the data analysis and writing is already exceptional.

@thefoxis
Copy link
Contributor

@borisschapira no sweat 🙂 English is my second language too and the Poles are apparently also very direct so I know what you mean. any feedback appreciated! I already responded / acted on some of your comments. all good finds 👍 thank you! ⚡

@exterkamp
Copy link
Contributor

Thanks for looking at my comments @thefoxis! I had a small nitpick with CLS, and ended up reading the whole chapter because it was such a good read. Really well written all round 💯

@rviscomi
Copy link
Member

Thanks for the review @exterkamp. Could you add yourself to the contributors list? (alphabetical by first name)

@noamr
Copy link

noamr commented Nov 29, 2020

A great read! I'm reviewing the material now, prepare for some comments :)

@thefoxis
Copy link
Contributor

thanks @noamr and @exterkamp! good comments all around, I’m addressing it along @rviscomi’s feedback :) a few more bits to go, but I can see the end now 🎉 glad you enjoyed reading so far!

@rviscomi rviscomi added ASAP This issue is blocking progress and removed analysis Querying the dataset labels Nov 30, 2020
@thefoxis
Copy link
Contributor

thefoxis commented Dec 1, 2020

@OBTo @rviscomi I believe I addressed all existing feedback and added a conclusion. FYI I removed captions since I figured with the markdown format I'll just submit them with the PR; let me know if that's suitable. feeling pretty good about it! let me know if there's anything else.

@dimension85 @borisschapira @estelle @zeman @rviscomi @OBTo @noamr @ashrith-kulai @Zizzamia @exterkamp if you'd like to add any more/first thoughts to the draft, you're welcome to. I'm not sure how much ability I will have to address big shifts in content, but fixes / clarifications / smaller suggestions shouldn't be an issue with the schedule I reckon 😅

@foxdavidj
Copy link
Contributor Author

@thefoxis Sounds like a solid plan to me. I'll look at it again this evening to see if I pick up on anything before we start the editing process :)

@rviscomi
Copy link
Member

rviscomi commented Dec 2, 2020

@thefoxis I'm excited to see this moving along! Thank you for your hard work getting it to this point. Can you open a PR to submit the markdown version of the draft? (the final milestone in the initial checklist)

I've stubbed out the markdown file already with some early metadata and you can see the 2019 version for reference. I'm happy to help convert the data viz to the correct figure format, if you leave them as TODOs/placeholders in the markdown file. Please also update the chapter metadata to remove anyone who hasn't contributed, add your bio, add features quote/stats, etc.

@thefoxis
Copy link
Contributor

thefoxis commented Dec 2, 2020

@rviscomi all done in #1608 👍

@foxdavidj
Copy link
Contributor Author

@thefoxis Just finished reading the chapter and quite enjoyed it. Great job. Just had a few small questions and suggestions I left in the Google Doc :)

@rviscomi rviscomi removed the ASAP This issue is blocking progress label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2020 chapter Tracking issue for a 2020 chapter writing Related to wording and content
Projects
None yet
Development

No branches or pull requests