Fix lighthouse errors (#1216)

HTTPArchive · Aug 18, 2020 · 6ad07e6 · 6ad07e6
1 parent 26ce215
commit 6ad07e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/static/css/page.css b/src/static/css/page.css
@@ -280,8 +280,7 @@
 }
 
 .authors .social a {
-  margin-right: 10px;
-  margin-right: 0.625rem;
+  margin: 0.25rem 1rem 0.25rem 0;
   white-space: nowrap;
   display: inline-flex;
   align-items: center;
@@ -298,7 +297,7 @@
 }
 
 .authors .social svg {
-  width: 1em;
+  width: 1.5em;
   height: auto;
   margin-right: 4px;
   margin-right: 0.25rem;

diff --git a/src/templates/base/2019/base_chapter.html b/src/templates/base/2019/base_chapter.html
@@ -134,7 +134,7 @@ <h2 id="authors">
                 <div class="social">
                   {% if authordata.twitter %}
                   <a class="twitter" href="https://twitter.com/{{ authordata.twitter }}" aria-labelledby="author-{{ author }}-twitter">
-                    <svg width="22" height="22" role="img" aria-hidden>
+                    <svg width="22" height="22" role="img">
                       <title id="author-{{ author }}-twitter">{{ onTwitter(authordata.twitter) }}</title>
                       <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#twitter"></use>
                     </svg>
@@ -143,7 +143,7 @@ <h2 id="authors">
                   {% endif %}
                   {% if authordata.github %}
                   <a class="github" href="https://github.com/{{ authordata.github }}" aria-labelledby="author-{{ author }}-github">
-                    <svg width="22" height="22" aria-hidden>
+                    <svg width="22" height="22">
                       <title id="author-{{ author }}-github">{{ onGitHub(authordata.github) }}</title>
                       <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#github"></use>
                     </svg>
@@ -152,7 +152,7 @@ <h2 id="authors">
                   {% endif %}
                   {% if authordata.linkedin %}
                   <a class="linkedin" href="https://www.linkedin.com/in/{{ authordata.linkedin }}/" aria-labelledby="author-{{ author }}-linkedin">
-                    <svg width="22" height="22" aria-hidden>
+                    <svg width="22" height="22">
                       <title id="author-{{ author }}-linkedin">{{ onLinkedIn(authordata.name) }}</title>
                       <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#linkedin"></use>
                     </svg>
@@ -161,7 +161,7 @@ <h2 id="authors">
                   {% endif %}
                   {% if authordata.website %}
                   <a class="website" href="{{ authordata.website }}" aria-labelledby="author-{{ author }}-website">
-                    <svg width="22" height="22" aria-hidden>
+                    <svg width="22" height="22">
                       <title id="author-{{ author }}-website">{{ website(authordata.name) }}</title>
                       <use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#globe"></use>
                     </svg>