switch to Node.js v16 #4776
Merged
switch to Node.js v16 #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
force-pushed
the
node16-upstream
branch
from
6b58a80
to
b78037e
Compare
- use 1.4 syntax to support `COPY --link` commands - set NODE_ENV=production - remove $WORK build arg
…ching - If e.g. `test` has been added in a command/step, removing it in a subsequent command/step does not have a positive effect on the image size. Rather, we add it .dockerignore to stop adding it in the first place. - node_modules/.cache & /tmp/Relay* are populated by Webpack plugins.
app/server.js reads .entrypoints.main.assets in order to generate an appropriate manifest and `preload` tags, but it doesn't need the rest. This is why we turn all stats off via `all: false` and then selectively turn `entrypoints` on. Before, stats.json was 82mb, now it is ~9kb.
Even if a commit has changed `yarn.lock`, we can use an old `.yarn/cache` directory, so that we don't have to fetch 99% of all dependencies again.
This reverts 32bbfa8, which reverts 3f6e105, which apparently failed because of an unrelated problem[1]. [1] https://github.com/HSLdevcom/digitransit-ui/actions/runs/4762670497/jobs/8469259999
This probably improves favicons-webpack-plugin's performance, as node_modules won't be resolved for resolving the path.
This speeds up the webpack build within the Docker image build significantly.
Co-Authored-By: Jannis R <[email protected]>
derhuerst
force-pushed
the
node16-upstream
branch
from
b78037e
to
d9b8b09
Compare
derhuerst
force-pushed
the
node16-upstream
branch
from
d9b8b09
to
b0ff3cd
Compare
…github actions cherry-pick of b8333bd
derhuerst
force-pushed
the
node16-upstream
branch
from
b0ff3cd
to
20bbed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes of and depends on PR #4545; Please review & merge that one first.
Proposed Changes
.nvmrc,engines.node: switch to Node.js v16Pull Request Check List
Review
(This is the upstream equivalent of embarkokc#21.)