Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update sentry #3695

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

WIP: Update sentry #3695

wants to merge 1 commit into from

Conversation

optionsome
Copy link
Member

This does not work yet. These changes were made in attempt to fix a memory leak that our current sentry version has with node 10 but this didn't fix it alone. We should probably first update other dependencies so that we can upgrade node to at least 12 if not 14. Also the browser sentry initialization does not work with these changes yet. We should probably try using @sentry/react instead of @sentry/browser.

Proposed Changes

  • Update sentry dependencies

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant