Fix a bit the performance of the LHCb geometry, some small bugs #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
So in these 2 commits I fix a bit the performance of the geometry caused by the VP subdetector because of it's many many layers of complexity from the .root level. I tried to remove all the volumes from the root file that would not harm the 3D modeling of the particular subdetector and right now as it is anything else can't be removed without having a visual impact on the actual geometry model. The minor fps boost is right now on my machine at around 14 fps on a laptop without a GPU. Disabling the VP geometry from the menu makes it 40 fps. But even on 14 fps it is pretty usable and fast, significantly faster than the previous 3-5 fps 😝 .
I also fixed a bug in the Rich geometry, in particular there are 2 Rich subdetectors in LHCb and when disabling them in the menu on the right only 1 of the 2 was being disabled. Now they do work properly.
That's all for now.
P.S. I still need to write my updates on the documentation part, I got the notes but didn't find the time to implement them yet, please do excuse me. I will though!
Thank you.