Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bit the performance of the LHCb geometry, some small bugs #342

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

andrewpap22
Copy link
Collaborator

Greetings,

So in these 2 commits I fix a bit the performance of the geometry caused by the VP subdetector because of it's many many layers of complexity from the .root level. I tried to remove all the volumes from the root file that would not harm the 3D modeling of the particular subdetector and right now as it is anything else can't be removed without having a visual impact on the actual geometry model. The minor fps boost is right now on my machine at around 14 fps on a laptop without a GPU. Disabling the VP geometry from the menu makes it 40 fps. But even on 14 fps it is pretty usable and fast, significantly faster than the previous 3-5 fps 😝 .

I also fixed a bug in the Rich geometry, in particular there are 2 Rich subdetectors in LHCb and when disabling them in the menu on the right only 1 of the 2 was being disabled. Now they do work properly.

That's all for now.

P.S. I still need to write my updates on the documentation part, I got the notes but didn't find the time to implement them yet, please do excuse me. I will though!

Thank you.

Copy link
Collaborator

@9inpachi 9inpachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewpap22!

This one is ready to merge, right?

@andrewpap22
Copy link
Collaborator Author

Yes @9inpachi !

I tested it locally and it should be good to go!

@9inpachi 9inpachi merged commit 7f6a45a into HSF:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants