Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests can't pass under EPEL #140

Open
moceap opened this issue Oct 21, 2021 · 3 comments
Open

Tests can't pass under EPEL #140

moceap opened this issue Oct 21, 2021 · 3 comments

Comments

@moceap
Copy link
Contributor

moceap commented Oct 21, 2021

When I try to build 0.7.2 all tests fail. They were pass in my last try (0.7.0).

--- command ---
10:54:19 /usr/bin/python3 /builddir/build/BUILD/raqm-0.7.2/x86_64-redhat-linux-gnu/../tests/runtest.py /builddir/build/BUILD/raqm-0.7.2/tests tests/raqm-test /builddir/build/BUILD/raqm-0.7.2/tests/cursor_position_GB5.test
--- stdout ---
Testing /builddir/build/BUILD/raqm-0.7.2/tests/cursor_position_GB5.test...
['tests/raqm-test', '--bytes', '006F 006D 0061 006E 00C2 0083 006F 006D 0061 006E', '--cluster', '4', '--position', '5000', '--font', '/builddir/build/BUILD/raqm-0.7.2/tests/fonts/sha1sum/bcb3b98eb67ece19b8b709f77143d91bcb3d95eb.ttf']
--- stderr ---
Traceback (most recent call last):
File "/builddir/build/BUILD/raqm-0.7.2/x86_64-redhat-linux-gnu/../tests/runtest.py", line 53, in
actual, ret = cmd(command)
File "/builddir/build/BUILD/raqm-0.7.2/x86_64-redhat-linux-gnu/../tests/runtest.py", line 13, in cmd
stderr=subprocess.PIPE, text=True)
TypeError: init() got an unexpected keyword argument 'text'

@khaledhosny
Copy link
Collaborator

The text argument in subprocess.Popen() was added in Python 3.7 but EPEL is using Python 3.6. I think the old universal_newlines option is equivalent, but I don’t have Python 3.6 to test this.

@moceap
Copy link
Contributor Author

moceap commented Oct 21, 2021

When I replaced (text) with (universal_newlines), tests pass except one:

The output from the failed tests:

47/47 raqm-doc-check FAIL 0.08s (exit status 1)


--- command ---
14:44:05 DOC_MAIN_SGML_FILE='raqm-docs.xml' DOC_MODULE='raqm' /usr/bin/gtkdoc-check
--- stdout ---
Cannot find DOC_MODULE in Makefile
-------

@khaledhosny
Copy link
Collaborator

No idea why this is failing, but you are using meson and the failure mentions Makefile which is odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants