fix(i18n): refine tasklistpane i18n #3600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3gf8jv4dv
changed the title
3gf8jv4dv
force-pushed
the
refine-tasklistpane-i18n
branch
from
ba60f4b to
97c2c94
Compare
|
cc @burningtnt, @Glavo, @yushijinhun, and @zkitefly |
zkitefly
approved these changes
Feb 17, 2025
3gf8jv4dv
force-pushed
the
refine-tasklistpane-i18n
branch
from
97c2c94 to
59ef878
Compare
3gf8jv4dv
force-pushed
the
refine-tasklistpane-i18n
branch
2 times, most recently
from
c8269cb to
7860781
Compare
The current TaskListPane may not look different for Chinese users, but the grammar is not quite right for English users. My previous series of PRs did not address this aspect due to the associated hard coding of the i18n key. I believe that revisions in this aspect can further improve the experience of Indo-European speakers. All languages except Japanese are ready for this PR.
3gf8jv4dv
force-pushed
the
refine-tasklistpane-i18n
branch
from
7860781 to
df81579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current TaskListPane may not look different for Chinese users, but the grammar is not quite right for English users.
My previous series of PRs did not address this aspect due to the associated hard coding of the i18n key.
I believe that revisions in this aspect can further improve the experience of Indo-European speakers.
All languages except Japanese are ready for this PR.
Todo
Image
Preview
BEFORE __________ AFTER
