Fix SQL wrong aggregate function usage #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just tested on MySQL 5.7 and PostgreSQL 10.something and it works. |
|
Thx |
HLeithner
pushed a commit
that referenced
this pull request
Apr 2, 2023
* Convert user plugins to service provider * form path * Update plugins/user/contactcreator/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/joomla/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/profile/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/terms/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/token/services/provider.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <[email protected]> * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <[email protected]> * revert debug * private * Fix account notification email language (#28) * Update plugins/user/joomla/src/Extension/Joomla.php Co-authored-by: heelc29 <[email protected]> * minor change --------- Co-authored-by: heelc29 <[email protected]> Co-authored-by: Tuan Pham Ngoc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#25052 .
Summary of Changes
See comments in the CMS PR:
joomla#25052 (comment)
joomla#25052 (comment)
joomla#25052 (comment)
Testing Instructions
Check on MySQL 8 or a lower supported version where sql_mode=only_full_group_by is set like it is in 8 by default, or on a PostgreSQL database that there is no error reported regarding aggregated query without GROUP BY.
Expected result
No invalid SQL according to common standards.
Actual result
Invalid SQL according to common standards.
Documentation Changes Required
None.