Skip to content

Get underling values of Fields #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 19, 2025
Merged

Get underling values of Fields #49

merged 11 commits into from
Aug 19, 2025

Conversation

@nickpdemarco
Copy link
Contributor

@nickpdemarco nickpdemarco commented Aug 14, 2025 •
edited
Loading

Currently, it does not seem possible to read the underling value of zngur fields in C++. This PR adds support for converting a Field<T> to a T, and adds corresponding docs and tests.

@nickpdemarco
Copy link
Contributor Author

nickpdemarco commented Aug 14, 2025

@HKalbasi it seems Rust 1.91 has started printing thread IDs on panics, which is breaking our diff-based example testing. Any suggestions on how to proceed? I don't see an obvious way to turn off that panic behavior.

@nickpdemarco
Copy link
Contributor Author

nickpdemarco commented Aug 14, 2025

Seems we may need #50 before merging this.

HKalbasi
HKalbasi reviewed Aug 14, 2025
View reviewed changes
@HKalbasi
Copy link
Owner

HKalbasi commented Aug 14, 2025

@HKalbasi it seems Rust 1.91 has started printing thread IDs on panics, which is breaking our diff-based example testing. Any suggestions on how to proceed? I don't see an obvious way to turn off that panic behavior.

Ah, this is rust-lang/rust#115746 . Let's use the stable compiler instead of nightly for now, and hope that they will make an option to disable this behavior before this hits stable. I like to avoid regex if possible, since it will break the ability of auto-fixing the tests.

@nickpdemarco nickpdemarco mentioned this pull request Aug 15, 2025
Closed
nickpdemarco
nickpdemarco commented Aug 15, 2025
View reviewed changes
@nickpdemarco
Copy link
Contributor Author

nickpdemarco commented Aug 18, 2025

@HKalbasi I'm trying to figure out why clang++ is not finding ld despite binutils being installed by default on our GH runner. Let me know if you've seen this before or have suggestions.

@HKalbasi
Copy link
Owner

HKalbasi commented Aug 18, 2025

IIRC examples enable lto with clang and use lld. Might be related.

@nickpdemarco
Copy link
Contributor Author

nickpdemarco commented Aug 18, 2025

Well, I'm not sure why this PR broke it, but setting CC explicitly and installing lld seemed to do the trick.

HKalbasi
HKalbasi approved these changes Aug 19, 2025
View reviewed changes
book/src/call_rust_from_cpp/fields.md Outdated
These wrappers now act as their underlying type `T` in many contexts:

- `Ref<T>` construction from any `Field*<T, OFFSET>`
- Implicit read via `operator T()` and `.read()` for value-like access
Copy link
Owner

@HKalbasi HKalbasi Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .read() is leftover.

Copy link
Contributor Author

@nickpdemarco nickpdemarco Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Thanks.

@HKalbasi HKalbasi requested a review from Copilot August 19, 2025 07:39

This comment was marked as spam.

Sign in to view

@HKalbasi HKalbasi merged commit 5d7a87c into HKalbasi:main Aug 19, 2025
3 checks passed
@nickpdemarco nickpdemarco deleted the nickpdemarco/fields branch August 19, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@HKalbasi HKalbasi HKalbasi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickpdemarco @HKalbasi