Skip to content

fix(matrix): complete Element SAS request flow - #5385

Draft
dajiaohuang wants to merge 1 commit into
HKUDS:mainfrom
dajiaohuang:draft/4841-matrix-sas-flow
Draft

fix(matrix): complete Element SAS request flow#5385
dajiaohuang wants to merge 1 commit into
HKUDS:mainfrom
dajiaohuang:draft/4841-matrix-sas-flow

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • accept modern Element m.key.verification.request events for allowed users and devices
  • send ready, reuse the existing matrix-nio SAS cryptographic flow, and send done only after verified MAC completion
  • reject stale, future, conflicting, or mismatched requests while preserving legacy direct-start behavior
  • document that this does not add cross-signing or bot-initiated verification

Draft scope

This is the smallest reviewable compatibility increment discussed in the issue. Cross-signing and bot-initiated verification remain outside this draft.

Relates to #4841.

Validation

  • Matrix channel test suite: 97 passed
  • Ruff: passed
  • BasedPyright: 0 errors, 0 warnings, 0 notes
  • git diff --check: passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant