fix(plugins): revalidate cached skill roots after package changes - #5369
Open
yu-xin-c wants to merge 2 commits into
Open
fix(plugins): revalidate cached skill roots after package changes#5369yu-xin-c wants to merge 2 commits into
yu-xin-c wants to merge 2 commits into
Conversation
Re-bin
force-pushed
the
contrib/plugin-activation-cache
branch
from
August 15, 2026 09:10
5c3255e to
2f8811d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agent Plugin activation is bound to an immutable package snapshot, but the filesystem read path reused cached plugin skill directories without checking whether the package had changed. An in-place replacement could therefore remain readable from a restricted project until another plugin discovery path happened to invalidate the cache.
What changed
The existing SHA-256 activation marker remains the source of truth; the metadata snapshot only decides when it must be checked again.
Verification
uv run --extra dev pytest tests/agent/test_agent_plugins.py tests/tools/test_read_enhancements.py -q(50 passed)uv run --extra dev ruff check nanobot/agent/plugins.py tests/agent/test_agent_plugins.pyuv run --extra dev basedpyright nanobot/agent/plugins.py