Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No repository as instance variables anymore. #53

Merged
merged 1 commit into from
Aug 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Controllers } from './controllers';
import { useContainer as routingUseContainer } from 'routing-controllers';
import { container } from 'tsyringe';

import { loadServices, loadFirebase, loadORM, loadRepositories } from './loaders';
import { loadServices, loadFirebase, loadORM } from './loaders';
import morgan from 'morgan';

const limiter = rateLimit({
Expand All @@ -23,7 +23,6 @@ const limiter = rateLimit({
const port = process.env.PORT || 3001;

loadServices();
loadRepositories();

loadORM().then(() => {
loadFirebase();
Expand Down
31 changes: 0 additions & 31 deletions src/loaders/RepositoryLoader.ts

This file was deleted.

1 change: 0 additions & 1 deletion src/loaders/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export { loadFirebase } from './FirebaseLoader';
export { loadServices } from './ServiceLoader';
export { loadORM } from './ORMLoader';
export { loadRepositories } from './RepositoryLoader';
17 changes: 7 additions & 10 deletions src/mappers/AppUserMapper.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,16 @@
import { AppUserEventRequest, AppUserEventResponse } from '@Payloads';
import { AppUser } from '@Entities';
import { AppUserService } from '@Services';
import { AppUserRepositoryToken } from '@Repositories';

import { Repository } from 'typeorm';
import { classToPlain, plainToClass } from 'class-transformer';
import { singleton, inject } from 'tsyringe';
import { getRepository } from 'typeorm';

@singleton()
export class AppUserMapper {
private appUserRepository: Repository<AppUser>;
private appUserService: AppUserService;

constructor(
@inject(AppUserRepositoryToken) appUserRepository: Repository<AppUser>,
@inject(AppUserService) appUserService: AppUserService
) {
this.appUserRepository = appUserRepository;
constructor(@inject(AppUserService) appUserService: AppUserService) {
this.appUserService = appUserService;
}

Expand All @@ -28,8 +22,10 @@ export class AppUserMapper {
* @returns {AppUser} A newly created AppUser entity.
*/
requestToNewEntity(appUserRequest: AppUserEventRequest): AppUser {
const appUserRepository = getRepository(AppUser);
const plainAppUserRequest: Object = classToPlain(appUserRequest);
return this.appUserRepository.create(plainAppUserRequest);

return appUserRepository.create(plainAppUserRequest);
}

/**
Expand All @@ -48,7 +44,8 @@ export class AppUserMapper {
const appUserObj: AppUser = appUserRequest as AppUser;
appUserObj.id = appUserId;

const appUser: AppUser = await this.appUserRepository.preload(appUserObj);
const appUserRepository = getRepository(AppUser);
const appUser: AppUser = await appUserRepository.preload(appUserObj);

return appUser;
}
Expand Down
19 changes: 8 additions & 11 deletions src/mappers/EventMapper.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
import { EventRequest, EventResponse } from '@Payloads';
import { Event } from '@Entities';
import { EventRepositoryToken } from '@Repositories';

import { Repository } from 'typeorm';
import { classToPlain, plainToClass } from 'class-transformer';
import { singleton, inject } from 'tsyringe';
import { singleton } from 'tsyringe';
import { getRepository } from 'typeorm';

@singleton()
export class EventMapper {
private eventRepository: Repository<Event>;

constructor(@inject(EventRepositoryToken) eventRepository: Repository<Event>) {
this.eventRepository = eventRepository;
}

requestToNewEntity(eventRequest: EventRequest): Event {
const eventRepository = getRepository(Event);
const plainEventRequest: object = classToPlain(eventRequest);
return this.eventRepository.create(plainEventRequest);

return eventRepository.create(plainEventRequest);
}

/**
Expand All @@ -33,7 +28,9 @@ export class EventMapper {
const eventObj: Event = eventRequest as Event;
eventObj.id = eventID; // preload expects an id.

const event: Event = await this.eventRepository.preload(eventObj);
const eventRepository = getRepository(Event);
const event: Event = await eventRepository.preload(eventObj);

if (event === undefined) {
return undefined;
}
Expand Down
22 changes: 0 additions & 22 deletions src/repositories/index.ts

This file was deleted.

20 changes: 10 additions & 10 deletions src/services/AppUserService.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
import { AppUser, AppUserRole } from '@Entities';
import { singleton } from 'tsyringe';
import { Any, Repository, getRepository } from 'typeorm';
import { Any, getRepository } from 'typeorm';

@singleton()
export class AppUserService {
private appUserRepository: Repository<AppUser>;

constructor() {
this.appUserRepository = getRepository(AppUser);
}

/**
* Stores the AppUser passed in as a parameter to the
* AppUser table.
Expand All @@ -18,7 +12,9 @@ export class AppUserService {
* @returns {Promise} The saved AppUser entity.
*/
async saveAppUser(appUser: AppUser): Promise<AppUser> {
return await this.appUserRepository.save(appUser);
const appUserRepository = getRepository(AppUser);

return await appUserRepository.save(appUser);
}

/**
Expand All @@ -28,7 +24,9 @@ export class AppUserService {
* @returns {AppUser[]} Array of AppUser entities.
*/
getMultipleAppUsers(ids: number[]): Promise<AppUser[]> {
return this.appUserRepository.find({ id: Any(ids) });
const appUserRepository = getRepository(AppUser);

return appUserRepository.find({ id: Any(ids) });
}

/**
Expand All @@ -38,7 +36,9 @@ export class AppUserService {
* @returns {Promise} An AppUser entity if it exists in AppUser table.
*/
getAppUserByEmail(email: string): Promise<AppUser | undefined> {
return this.appUserRepository.findOne({ email });
const appUserRepository = getRepository(AppUser);

return appUserRepository.findOne({ email });
}

/**
Expand Down
17 changes: 6 additions & 11 deletions src/services/AttendanceService.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
import { Attendance, AppUser, AppUserRole, Event } from '@Entities';
import { AttendanceRepositoryToken } from '@Repositories';

import { Repository } from 'typeorm';
import { singleton, inject } from 'tsyringe';
import { getRepository } from 'typeorm';
import { singleton } from 'tsyringe';

@singleton()
export class AttendanceService {
private attendanceRepository: Repository<Attendance>;

constructor(@inject(AttendanceRepositoryToken) attendanceRepository: Repository<Attendance>) {
this.attendanceRepository = attendanceRepository;
}

/**
* Creates a new Attendance entity, then attempts to insert it into the DB.
*
Expand All @@ -20,12 +13,14 @@ export class AttendanceService {
* @returns {Promise} A new Attendance entity, but undefined for duplicate Attendance entities.
*/
async registerAttendance(event: Event, attendee: AppUser): Promise<Attendance | undefined> {
const attendanceRepository = getRepository(Attendance);

const { role } = attendee;
const attendance = { event, attendee, isInductee: role === AppUserRole.INDUCTEE };
const newAttendance = this.attendanceRepository.create(attendance);
const newAttendance = attendanceRepository.create(attendance);

try {
await this.attendanceRepository.insert(newAttendance);
await attendanceRepository.insert(newAttendance);
} catch {
return undefined;
}
Expand Down
30 changes: 18 additions & 12 deletions src/services/EventService.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
import { Event, AppUser, Attendance, RSVP } from '@Entities';
import { EventRepositoryToken } from '@Repositories';
import { AttendanceService } from './AttendanceService';
import { RSVPService } from './RSVPService';

import { Repository } from 'typeorm';
import { singleton, inject } from 'tsyringe';
import { getRepository } from 'typeorm';

@singleton()
export class EventService {
private eventRepository: Repository<Event>;
private attendanceService: AttendanceService;
private rsvpService: RSVPService;

constructor(
@inject(EventRepositoryToken) eventRepository: Repository<Event>,
@inject(AttendanceService) attendanceService: AttendanceService,
@inject(RSVPService) rsvpService: RSVPService
) {
this.eventRepository = eventRepository;
this.attendanceService = attendanceService;
this.rsvpService = rsvpService;
}
Expand All @@ -28,7 +24,9 @@ export class EventService {
* @returns {Promise} Saved event.
*/
async saveEvent(event: Event): Promise<Event> {
return this.eventRepository.save(event);
const eventRepository = getRepository(Event);

return eventRepository.save(event);
}

/**
Expand All @@ -37,7 +35,9 @@ export class EventService {
* @returns {Event[]} Array of all events.
*/
getAllEvents(): Promise<Event[]> {
return this.eventRepository.find();
const eventRepository = getRepository(Event);

return eventRepository.find();
}

/**
Expand All @@ -47,7 +47,9 @@ export class EventService {
* @returns {Promise} Event with given id.
*/
getEventById(id: number): Promise<Event | undefined> {
return this.eventRepository.findOne({ id });
const eventRepository = getRepository(Event);

return eventRepository.findOne({ id });
}

/**
Expand All @@ -57,8 +59,10 @@ export class EventService {
* @returns {Promise} Deleted event.
*/
async deleteEvent(id: number): Promise<Event | undefined> {
const event = await this.eventRepository.findOne({ id });
return event ? this.eventRepository.remove(event) : undefined;
const eventRepository = getRepository(Event);
const event = await eventRepository.findOne({ id });

return event ? eventRepository.remove(event) : undefined;
}

/**
Expand All @@ -74,7 +78,8 @@ export class EventService {
eventId: number,
appUser: AppUser
): Promise<Attendance | undefined> {
const event = await this.eventRepository.findOne({ id: eventId });
const eventRepository = getRepository(Event);
const event = await eventRepository.findOne({ id: eventId });
const newAttendance = await this.attendanceService.registerAttendance(event, appUser);

return newAttendance;
Expand All @@ -89,7 +94,8 @@ export class EventService {
* @returns {Promise} A new RSVP entity.
*/
async registerEventRSVP(eventId: number, appUser: AppUser): Promise<RSVP> {
const event = await this.eventRepository.findOne({ id: eventId });
const eventRepository = getRepository(Event);
const event = await eventRepository.findOne({ id: eventId });
const newRSVP = await this.rsvpService.registerRSVP(event, appUser);

return newRSVP;
Expand Down
20 changes: 7 additions & 13 deletions src/services/RSVPService.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
import { AppUser, Event, RSVP } from '@Entities';
import { RSVPRepositoryToken } from '@Repositories';
import { singleton } from 'tsyringe';

import { Repository } from 'typeorm';
import { singleton, inject } from 'tsyringe';
import { AppUser, Event, RSVP } from '@Entities';
import { getRepository } from 'typeorm';

@singleton()
export class RSVPService {
private rsvpRepository: Repository<RSVP>;

constructor(@inject(RSVPRepositoryToken) rsvpRepository: Repository<RSVP>) {
this.rsvpRepository = rsvpRepository;
}

/**
* Creates a new RSVP entity, then attempts to insert it into the DB.
*
Expand All @@ -20,11 +13,12 @@ export class RSVPService {
* @returns {Promise} A new RSVP entity, but undefined for duplicate RSVP.
*/
async registerRSVP(event: Event, appUser: AppUser): Promise<RSVP | undefined> {
const RSVP = { event, appUser };
const newRSVP = this.rsvpRepository.create(RSVP);
const rsvpRepository = getRepository(RSVP);
const rsvpBeingProcessed = { event, appUser };
const newRSVP = rsvpRepository.create(rsvpBeingProcessed);

try {
await this.rsvpRepository.insert(newRSVP);
await rsvpRepository.insert(newRSVP);
} catch {
return undefined;
}
Expand Down