Skip to content

Conversation

@pp-mo
Copy link

@pp-mo pp-mo commented May 16, 2025

Some wild suggestions

Not ready to merge !

jfrost-mo and others added 30 commits March 1, 2025 16:12
* Correct unit to units in AuxCoord docstring

Fixes SciTools#6347

* Add whatsnew entry
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.02.3 to 2025.03.1.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.02.3...2025.03.1)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Use realized data in benchmarks when requested

* Add whatsnew
…#6325)

* Fix issue where the mask of Dask arrays was ignored and improve tests

* Optimize unmasked numpy arrays

* Add whatsnew

* Use dask.array.blockwise for array comparison

* Faster comparison

* Avoid flattening arrays

* Avoid checking points if one coord has bounds and the other does not have them

* Small simplification

* Add test

* Use a separate map and reduce operation to avoid running out of memory on large arrays

* Correct order of checking if array is floating point dtype

Also consider non-floating point arrays equal with withnans=False

---------

Co-authored-by: Patrick Peglar <[email protected]>
…s#6340)

* Initial workaround - if variable is a "str" type then force it to load.
Would be better to force all Variable Length types to be lazy, but can't
ascertain this information from the CFAuxiliaryCoordinateVariable instance.

* Added some TODO comments

* Working solution that checks for VLEN arrays and handles the special
variable length "str" case.

* Formatting updates

* Added size hinting of variable length arrays using CHUNK_CONTROL context manager

* Access netCDF variable `datatype` via `cf_var.cf_data` to avoid Mock failures.

* Make check on cf_var.cf_data.datatype optional as it assumes underlying
storage is netCDF (which for this module is true, but for mock testing
is not)

* Added warning category

* Added unit tests for VLen arrays.

* Use 'safe-access' version of netCDF4.VLType to satisfy coding-standards checker.

* Updates to comments and added _MEAN_VL_ARRAY_LEN as module variable

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Restored accidentally removed comment

* Updated docstring and added docs

* Updated Whats New

* Fixed some typos in docs

* Fixed doctest indent

* Missing imports for doctest

* Rewording of docs

* Missing black lines in doctest

* Update lockfiles with iris-sample-data

* Better URL for variable length types [Review comment]

* Slight rewording of docs and fix some typos [Review comments]

* reworded hinting section

* Typo

---------

Co-authored-by: Patrick Peglar <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.7 → v0.9.9](astral-sh/ruff-pre-commit@v0.9.7...v0.9.9)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Remove unused 'unique' option from load collections and combine methods.

* Reinstate 'unique=False' in combine merges to fix load().

* Fix typing for combine submodule.

* More typing and other small improvements to combine code.

* Move loading-specific parts from CombineOptions to LoadPolicy.

* Fix LoadPolicy error handling + test.

* Properly support merge_unique, and add equalise_cubes.

* Allow LoadPolicy.context with no settings arg.

* Turn off varying-reference support for 'legacy' load setting only.

* Implement combine_cube as util, and redirect test.

* Small docs fixes.

* Add functioning doctest example for combine_cubes.

* Further doctest fixes.

* Add cubelist combine methods.

* Better documentation of CombineOptions and LoadPolicy settings.

* Recombine LoadPolicy into CombineOptions.

* Fix doctest.

* Rework CombineOptions.set() tests to cover context() method also.

* Add tests for cubelist combine functions (and fix).

* Add tests for individual combine control keywords.

* Added whatsnew, and minimal links in other docs sections.

* Review changes: docs improvements; docstrings for cubelist combine methods.

* Tiny formatting correction.

* Review changes: docs explain not to assign to iris.COMBINE_POLICY.

* Review changes: fix obsolete comments + todos in testcode.

* Review changes: add test for string arg + kwargs.

* Review changes: remove obsolete TODO notes.
…SciTools#6338)

* Basic LOAD_PROBLEMS object.

* Minimum docstring for LOAD_PROBLEMS.

* Working handling of names and dimension coords.

* Warn user of load problems.

* Docstring and UX improvements.

* What's New entry.

* Fix doctests.

* Fix tests.

* Fix doctests for 3.13.

* New tests for actions.

* Updated load problems tests for names.

* Licence header.

* Tidy up code modifications.

* Convenience - get_latest_load_problem.

* Tests for _add_or_capture.

* Test for build_raw_cube.

* Make more methods private.

* Fix doctest.

* Factor out add_method.

* Remove stack_trace TODO.

* Correct docstring of _add_or_capture.

* Extra comments.

* Refactor to create the LoadProblems class.

* Fix doctest.

* What's New improvements.

* Encase coordinate name in quotes.

* More robust LoadProblems testing.

* Remove TODO tags following review discussion.

* Propose mail-archive for addition to linkcheck_ignore.
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.9 → v0.9.10](astral-sh/ruff-pre-commit@v0.9.9...v0.9.10)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.03.1 to 2025.03.3.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.03.1...2025.03.3)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Whats new updates for v3.12.0 .

* Review changes: whatsnew fix.

* Add link to ignored list.
Mergeback from v3.12.0 release.
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.2](astral-sh/ruff-pre-commit@v0.9.10...v0.11.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.03.3 to 2025.03.4.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.03.3...2025.03.4)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martin Yeo <[email protected]>
Co-authored-by: Lockfile bot <[email protected]>
Co-authored-by: Martin Yeo <[email protected]>
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.03.4 to 2025.03.8.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.03.4...2025.03.8)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add lychee-based linkcheck workflow.

* Remove old nox-based per-PR linkcheck.

* Remove nox-linkcheck from python-version-checks test.

* Configure manifest to exclude the linkcheck ignores file.

* Update .github/workflows/ci-linkchecks.yml

Co-authored-by: Martin Yeo <[email protected]>

* Update .github/workflows/ci-linkchecks.yml

Co-authored-by: Martin Yeo <[email protected]>

* Add links badge to README.

* Test urls in all files python, exclude or replace failing urls in python.

* Run checks every day, including weekends.

* Apply Iris-friendly labels to linkcheck failure Issues.

---------

Co-authored-by: Martin Yeo <[email protected]>
dependabot bot and others added 7 commits May 22, 2025 09:57
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.05.2 to 2025.05.3.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.05.2...2025.05.3)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-version: 2025.05.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Allow masked data to be passed into a Cell, and by extensions a Coord.

* Handled case where integer array with masked values could not be created.

* Handle case where reading of scalar masked value from netCDF file
looses the original dtype.

* Removed some comments

* Removed fill_value keyword to masked_array creation - wasn't fixing the
issue with numpy warnings about NaNs.

* Single method for handling points arrays with masked data

* Refactored to add small inline helper function to add AuxCoord

* Refactored the masked array handling and now filling masked arrays with default fill type.

* Added test for Cell hashing

* test_Cell.py: Converted unittest to pytest

* Added tests for merging of scalar aux coords with mising data.

* Removed unnecessary __main__ entry point from test_Cell.py

* Missing hash test for bounded points

* More rigorous test on masked data of merged AuxCoord

* Migrated test_merge.py to pytest.

* Moved tests/test_merge.py to tests/unit/merge/test_merge.py

* What's new entry.

* Fixed some typos in comment

* Split out integration test from unit/merge/test_merge.py to
integration/merge/test_merge.py
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.10 → v0.11.11](astral-sh/ruff-pre-commit@v0.11.10...v0.11.11)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pp-mo pp-mo marked this pull request as ready for review May 28, 2025 18:31
dependabot bot and others added 2 commits May 29, 2025 09:43
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2025.05.3 to 2025.05.4.
- [Release notes](https://github.com/scitools/workflows/releases)
- [Commits](SciTools/workflows@2025.05.3...2025.05.4)

---
updated-dependencies:
- dependency-name: scitools/workflows
  dependency-version: 2025.05.4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pp-mo pp-mo force-pushed the pp_derived_bounds branch from b2c79b5 to ee74499 Compare May 29, 2025 14:48
@pp-mo pp-mo force-pushed the pp_derived_bounds branch 2 times, most recently from ccda746 to 6aa9c81 Compare May 30, 2025 11:38
@pp-mo pp-mo force-pushed the pp_derived_bounds branch from bba4326 to 957161f Compare May 30, 2025 15:09
@pp-mo pp-mo closed this Jun 12, 2025
@pp-mo pp-mo deleted the pp_derived_bounds branch June 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants