-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for MediaInfo stuff. Helper works! But View has to be tested (!) #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks ill review this today when home before pushing and double check to make sure all works. |
Cool stuff. Ryuu said he might check it for errors as well, so with a bit
of luck not much work will be left for ya. :)
…On Fri, Dec 22, 2017 at 7:04 PM, HDVinnie ***@***.***> wrote:
thanks ill review this today when home before pushing and double check to
make sure all works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#69 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGVTJQLGmoi7QaOsrUyJcQsQT_JP5rIvks5tC-8vgaJpZM4RLQFO>
.
|
Fix Mediainfo
- this goes in hand with your PR to master UNIT3D branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did test the MediaInfo helper with a local script, but I don't have the environment for the whole Laravel thing, so someone will have to test whether the view works as it is. I didn't get any syntax errors, so I hope there won't be any major issues.
Changed up a couple of things, like adding the "title" property to the display and changing "codec" to "format" for subtitles (because it doesn't work well for m2ts files).
Also, I removed the blanket strtolower and added it where it was necessary (to section and property recognition and some of the property parsers). The upside of this is that a lot of MediaInfo information that uses both uppercase and lowercase is now fixed.
Added a shitton of security tests for non-existent properties etc. (both in view and helper), so there should be no more exceptions.