(Add) User Request Sharing + Stats + Privacy Fixes #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add load for privacy.
Add load for peers and history.
Add support for new privacy options.
Placeholder isVisible.
Add request and other groups.
New privacy options.
For new requests filter.
For fixed nav bar.
Respect new visible flag.
Add new options.
Respect new privacy.
Respect new privacy.
Nav fix.
Not needed
For new nav.
Fix top nav.
Check if requested should be shown.
May be removed soon.
Move resurrections.
Move resurrections.
New features.
Not needed
For user requests.
New options.
For user requests.
Nav fix.
Add request stats.
User requests.
Update nav.
For privacy updates/requests.
Dump privacy.
HDVinnie
reviewed
Feb 22, 2019
| @@ -112,6 +113,9 @@ public function profile($slug, $id) | |||
| $realdownload = $user->downloaded + $bondownload; | |||
| $invitedBy = Invite::where('accepted_by', '=', $user->id)->first(); | |||
|
|
|||
| $requested = TorrentRequest::where('user_id','=',$user->id)->count(); | |||
| $filled = TorrentRequest::where('filled_by','=',$user->id)->where('approved_by','is not','null')->count(); | |||
There was a problem hiding this comment.
This query is not valid. Should be:
$filled = TorrentRequest::where('filled_by','=',$user->id)->whereNotNull('approved_by')->count();
There was a problem hiding this comment.
It's dirty, but it's not not valid.
Fixing.
Clean dirty queries.
Cleaned.
Cleaned.
Apply fixes from StyleCI
Remove non needed queries.
Nuke stats
Nuke stats
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Users can now view other users requests (if not anonymous and if user doesnt hide privacy).
2: Admins/staff can see requests.
3: New stat on profile: requested and requests filled.
4: Fix missing hide from peer block (by adding new group targeted setting).
5: Add hide from online block (by adding new group targeted setting).
Close out bug + user request.