(Fix) Receiving chat pms from other users while in chat pm #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When conversing in a chat pm and you receive a chat pm from another user, their message will appear inside of the current chat pm you have open. This is because of incorrect logic inside Chatbox.vue. When user A sends a message to user B via the Chatter event, the message will have a subproperty `user` with user A's id. But user A is user B's target. So, these two properties need to be compared to determine if the message should be saved or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When conversing in a chat pm and you receive a chat pm from another user, their message will appear inside of the current chat pm you have open.
This is because of incorrect logic inside Chatbox.vue. When user A sends a message to user B via the Chatter event, the message will have a subproperty
userwith user A's id. But user A is user B's target. So, these two properties need to be compared to determine if the message should be saved or not.