(Refactor) Use ANSI-compatible syntax for raw database queries #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I runtime tested all the changed queries (except the migrations, but those are tested in ci already). We can worry about the remaining functions later in a "part 2" pr. The remaining functions will likely need to be duplicated in php checking the database system currently used and having 2 separate queries. |
HDVinnie
approved these changes
Nov 4, 2024
Roardom
added a commit
to Roardom/UNIT3D-Community-Edition
that referenced
this pull request
Nov 26, 2024
Regression from HDInnovations#4300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #3763 (and overall good practice)
The following still needs to be fixed before postgres is compatible:
@variables in refund commandFind replacements for the following functions:
HEX,UNHEX,JSON_ARRAYAGG,JSON_OBJECT,JSON_ARRAYSUBSTRING_INDEXUNIX_TIMESTAMP,DATE,FROM_DAYS,TO_DAYSINET6_NTOA