(Refactor) Normalize forum aggregates #4292
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roardom
force-pushed
the
normalize-forums
branch
from
afc74cb to
704d3f6
Compare
Even though the queries were ultra efficient before (always less than 5ms), the total combined cpu execution time for forums is not greater than 0.3% of all total execution time. Opt for cleaner code and a normalized database instead. In a forum with 40k posts and 5k topics: Topic index: 26 ms -> 83ms. The forum category topic index: 29 ms -> 63 ms. The forum index: 20 ms -> 55 ms. The forum topic index: 19 ms -> 25 ms. User topics: 18 ms -> 21 ms. Subscriptions: 19 ms -> 20 ms. These numbers are very reasonable and normalization should be fine here. Unfortunately, Laravel doesn't have a function for hasManyThrough()->latestOfMany() so the eager load has to be done manually.
Roardom
force-pushed
the
normalize-forums
branch
from
704d3f6 to
f0ce785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the queries were ultra efficient before (always less than 5ms), the total combined cpu execution time for forums is not greater than 0.3% of all total execution time. Opt for cleaner code and a normalized database instead.
In a forum with 40k posts and 5k topics:
Topic index: 26 ms -> 83ms.
The forum category topic index: 29 ms -> 63 ms.
The forum index: 20 ms -> 55 ms.
The forum topic index: 19 ms -> 25 ms.
User topics: 18 ms -> 21 ms.
Subscriptions: 19 ms -> 20 ms.
These numbers are very reasonable and normalization should be fine here.
Unfortunately, Laravel doesn't have a function for hasManyThrough()->latestOfMany() so the eager load has to be done manually.
TODO: topic reads