Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Validation for torrent request updates #4270

Conversation

thepolishplumber
Copy link

Hi,

Updated the validation rules in UpdateTorrentRequestRequest so they match the ones in StoreTorrentRequestRequest. The change came about because updating requests with no_meta category would break on validation. Weren't sure if any test needed updating.

…evant to the updated torrent request's category
@thepolishplumber thepolishplumber changed the title (Fix): validation for torrent request updates (Fix) Validation for torrent request updates Oct 22, 2024
Copy link
Collaborator

@HDVinnie HDVinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the return for new conditional rule so CI passes for larastan

@thepolishplumber
Copy link
Author

Done.

@HDVinnie
Copy link
Collaborator

Done.

Thanks

@HDVinnie HDVinnie merged commit e070133 into HDInnovations:8.x.x Oct 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants