(Add) Client torrent size sum to profile page #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query's execution time is increased from 10 ms to ~550 ms for power users with a few thousand torrents, or ~30 ms for average users with a few dozen torrents. Is the increased page load time worth its usefulness?
|
Can we test this temporarily in an environment with a tuned database and see how fast the queries load? I've got a feeling there's more to the story than my numbers tell. Considering the usefulness of this PR, I'd like to double check. |
Will test in a tuned production environment this weekend and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query's execution time is increased from 10 ms to ~550 ms for power users with a few thousand torrents, or ~30 ms for average users with a few dozen torrents. Is the increased page load time worth its usefulness?