#1781 - fix 405 error during twostep workflow from user settings page

[glennforrest]

Addresses the 405 error described in the following issue

[HDVinnie]

@glennforrest Im confused by this as its already defined

UNIT3D-Community-Edition/routes/web.php

Line 344 in dcbef0d

Route::post('/{username}/settings/change_twostep', [App\Http\Controllers\UserController::class, 'changeTwoStep'])->name('change_twostep');

and should be a POST.

Is used here

UNIT3D-Community-Edition/resources/views/user/security.blade.php

Lines 158 to 183 in 51402ce

	@if (config('auth.TwoStepEnabled') == true)
	<div role="tabpanel" class="tab-pane" id="twostep">
	<form role="form" method="POST"
	action="{{ route('change_twostep', ['username' => $user->username]) }}">
	@csrf
	<div class="well">
	<h2 class="text-bold">Two Step Authentication</h2>
	<hr>
	<label for="twostep" class="control-label">Use Two Step Auth?</label>
	<div class="radio-inline">
	<label><input type="radio" name="twostep" @if ($user->twostep == 1) checked @endif
	value="1">@lang('common.yes')</label>
	</div>
	<div class="radio-inline">
	<label><input type="radio" name="twostep" @if ($user->twostep == 0) checked
	@endif value="0">@lang('common.no')</label>
	</div>
	<br>
	</div>
	<div class="well text-center">
	<button type="submit" class="btn btn-primary">Save Changes</button>
	</div>
	</form>
	</div>
	</div>
	@endif

[glennforrest]

Hey, so my idea about a fix for this was basically to just create a redirect to prevent the 405 method not allowed error by defining the GET route. So I just chucked this in the existing controller method, I figured this would be an easier fix than dealing with the whole nextURI set up.

[HDVinnie]

Makes sense.

[HDVinnie]

Not sure why this is done when its a POST route.

[glennforrest]

You can define both in laravel routes, similar to how a PUT request to /posts/{post} typically resolves to an update request whereas a DELETE request to the same uri /posts/{post}` resolves to a destroy/delete method.

Can shift this to a completely separate method on the controller if you'd prefer?

[HDVinnie]

No its fine.