Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Condense and rearrange torrent general info #1884

Merged
merged 10 commits into from
Sep 5, 2021
Merged

(Update) Condense and rearrange torrent general info #1884

merged 10 commits into from
Sep 5, 2021

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Sep 3, 2021

Rearranges the torrent general info layout to be more condensed.

Changes:

  • Hovering over "n days ago" shows you the ISO timestamp
  • Hovering over the icons show the full name, so "Featured for x days", "Freeleech", etc
  • Hovering over the size gives you the estimated ratio after download
  • Hovering over the freeleech token buttons shows you how many fl tokens you have
  • Hovering over the seeder, leecher, times figures shows "n seeders", n leechers", "n times" respectively
  • Seed and leech counts links to the peers page
  • Times count link to the history page
  • Moderation buttons moved to dedicated panel
  • Moved torrent name front and center

Before:
rearrange_before

After:
rearrange_after

Links the "View Peers" and "View History" pages into the seeds/leeches and completed stats respectively to condense space
Move torrent timestamp and estimated ratio into tooltips to condense space
Move "Use a freeleech token" button to beside the download button to condense space
Only show 1 icon for freeleech regardless of how many freeleech discounts have been assigned. Same with double upload.
Convert all discounts to icons with the discount displayed in tooltip.
Add more torrent status to discounts in torrent general info
Move editing/internal/moderation controls to dedicated panel
Condenses and organizes general info from the table view into 2 lines
@clandestine8
Copy link
Contributor

I think the icons don't provide enough context for what they represent. Adding labels or additional context to the icons would help. Users shouldn't have to hover to be able to read the information on the screen.

I would like to see the expanded view preserved behind a toggle, especially since there is information that is not carried over to the new layout. This could also allow for further condensing as the less important details could be hidden in the expanded view.

We should also get some feedback from the sponsors since this is a key area of the project.

Displays the legacy torrent general info when the panel header is clicked
@Roardom
Copy link
Collaborator Author

Roardom commented Sep 4, 2021

The legacy layout can now be toggled by clicking on the "General" header similar to how the raw MediaInfo works

Copy link
Contributor

@clandestine8 clandestine8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with the toggle added, I think we are good with this.

Copy link
Collaborator

@HDVinnie HDVinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDVinnie HDVinnie merged commit 084ee13 into HDInnovations:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants