(Update) Improve Linkify, escape special chars for BBcode #1769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with
<
and>
characters in BBcode. Currently this text:Produces the following HTML:
Notice the wrong
<toshiro>
tags.Also
<span>
inside<span>
caused text to be big (wrong style removed).Improves Linkify function.
Current regex is outdated and doesn't work for domains with 4+ chars (like
unit3d.site
) because of[a-zA-Z]{2,3}
.In general, finding and highlighting links is not a simple task, so it's better to use a dedicated package.
I compared all modern ones and vstelmakh/url-highlight seemed to be the best. See examples.
It works fine with existing urls, that's why it was necessary to put
->linky
last after->parse
. Different order caused incorrect html.