Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 9 Shift #1356

Merged
merged 2 commits into from
May 27, 2020
Merged

PHPUnit 9 Shift #1356

merged 2 commits into from
May 27, 2020

Conversation

HDVinnie
Copy link
Collaborator

@HDVinnie HDVinnie commented May 26, 2020

This pull request contains changes for upgrading to PHPUnit 9 automated by the PHPUnit 9 Shift.

Before merging, you should review all comments and commit any changes to the shift-28388 branch.

php-shift added 2 commits May 26, 2020 00:59
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type:

- `setUpBeforeClass()`
- `setUp()`
- `assertPreConditions()`
- `assertPostConditions()`
- `tearDown()`
- `tearDownAfterClass()`
- `onNotSuccessfulTest()`

[1]: https://phpunit.de/announcements/phpunit-8.html
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1356 into master will increase coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1356      +/-   ##
============================================
+ Coverage     26.14%   27.16%   +1.02%     
  Complexity     4246     4246              
============================================
  Files           304      304              
  Lines         13353    13353              
============================================
+ Hits           3491     3628     +137     
+ Misses         9862     9725     -137     
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/Auth/TwoStepController.php 64.10% <0.00%> (-3.85%) 18.00% <0.00%> (ø%)
app/Http/Controllers/CommentController.php 78.88% <0.00%> (+0.37%) 46.00% <0.00%> (ø%)
app/Http/Controllers/AnnounceController.php 45.66% <0.00%> (+0.39%) 66.00% <0.00%> (ø%)
app/Http/Controllers/API/TorrentController.php 61.70% <0.00%> (+0.85%) 108.00% <0.00%> (ø%)
app/Models/User.php 41.66% <0.00%> (+1.19%) 122.00% <0.00%> (ø%)
app/Http/Controllers/FollowController.php 77.77% <0.00%> (+3.70%) 7.00% <0.00%> (ø%)
app/Services/Data/Movie.php 33.33% <0.00%> (+15.87%) 40.00% <0.00%> (ø%)
app/Services/MovieScrapper.php 83.33% <0.00%> (+22.22%) 10.00% <0.00%> (ø%)
app/Services/Clients/Client.php 86.20% <0.00%> (+24.13%) 15.00% <0.00%> (ø%)
app/Services/Clients/TmdbClient.php 43.77% <0.00%> (+38.24%) 90.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851c7ae...d8b1887. Read the comment docs.

@HDVinnie HDVinnie merged commit 3981b8d into master May 27, 2020
@HDVinnie HDVinnie deleted the shift-28388 branch May 27, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants