Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conversion of tables to BBCodeConverter.php #1269

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

fionera
Copy link
Contributor

@fionera fionera commented Apr 10, 2020

Closes #1267

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #1269 into master will decrease coverage by 0.07%.
The diff coverage is 3.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1269      +/-   ##
============================================
- Coverage     26.28%   26.20%   -0.08%     
- Complexity     4182     4188       +6     
============================================
  Files           297      297              
  Lines         13167    13195      +28     
============================================
- Hits           3461     3458       -3     
- Misses         9706     9737      +31     
Impacted Files Coverage Δ Complexity Δ
app/Helpers/BBCodeConverter.php 0.00% <0.00%> (ø) 56.00 <6.00> (+6.00)
app/Console/Commands/TestMailSettings.php 60.00% <100.00%> (ø) 2.00 <0.00> (ø)
app/Notifications/NewUploadTip.php 0.00% <0.00%> (-100.00%) 3.00% <0.00%> (ø%)
app/Helpers/TorrentHelper.php 0.00% <0.00%> (-30.00%) 10.00% <0.00%> (ø%)
app/Models/Torrent.php 20.28% <0.00%> (-8.70%) 31.00% <0.00%> (ø%)
app/Http/Controllers/API/TorrentController.php 60.85% <0.00%> (-6.81%) 108.00% <0.00%> (ø%)
app/Http/Controllers/BonusController.php 89.09% <0.00%> (-0.27%) 52.00% <0.00%> (ø%)
app/Http/Controllers/AnnounceController.php 45.91% <0.00%> (ø) 66.00% <0.00%> (ø%)
app/Models/User.php 39.68% <0.00%> (+1.98%) 122.00% <0.00%> (ø%)
app/Helpers/StringHelper.php 16.00% <0.00%> (+2.00%) 41.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca5ba7...88f53ba. Read the comment docs.

@HDVinnie HDVinnie merged commit ba96905 into HDInnovations:master Apr 10, 2020
@fionera fionera deleted the add-table-support branch April 10, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BBCodeConverter is missing Table support
2 participants