Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Test Email command #1261

Merged
merged 3 commits into from
Apr 7, 2020
Merged

(Update) Test Email command #1261

merged 3 commits into from
Apr 7, 2020

Conversation

PyR8zdl
Copy link
Contributor

@PyR8zdl PyR8zdl commented Apr 1, 2020

Changed Test Email command to use owner email set in env instead of using mysql query to pluck email using hardcoded default owner user ID.

This is needed incase a tracker decides to change owners. They can easily change the owner info in env file and test emails will just work.

PyR8zdl added 2 commits April 1, 2020 18:17
Changed Test Email command to use owner email set in env instead of using mysql query to pluck email using hardcoded default owner user ID.

This is needed incase a tracker decides to change owners. They can easily change the owner info in env file and test emails will just work.
@HDVinnie HDVinnie changed the title Update Test Email command (Update) Test Email command Apr 7, 2020
@HDVinnie
Copy link
Collaborator

HDVinnie commented Apr 7, 2020

Its considered bad practice to make a direct call to the .env file. You should instead call the other.php config which access's the .env var.

    /*
    |--------------------------------------------------------------------------
    | Site email
    |--------------------------------------------------------------------------
    |
    | Email address to send emails
    |
    */

    'email' => env('DEFAULT_OWNER_EMAIL', '[email protected]'),

@HDVinnie HDVinnie merged commit 9ca5ba7 into HDInnovations:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants