Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Tipping regression #1242

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Conversation

cbj4074
Copy link
Contributor

@cbj4074 cbj4074 commented Mar 11, 2020

57212ca introduced the following change:

$post = Post::with('topic')->findOrFail($id);

This broke Tipping as described in:

#1193

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #1242 into master will increase coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1242      +/-   ##
============================================
+ Coverage     26.43%   27.78%   +1.35%     
  Complexity     4157     4157              
============================================
  Files           297      297              
  Lines         13129    13129              
============================================
+ Hits           3470     3648     +178     
+ Misses         9659     9481     -178
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/BonusController.php 89.36% <100%> (ø) 52 <6> (ø) ⬇️
app/Models/Torrent.php 24.63% <0%> (-4.35%) 31% <0%> (ø)
app/Http/Controllers/Auth/TwoStepController.php 64.1% <0%> (-3.85%) 18% <0%> (ø)
app/Http/Controllers/API/TorrentController.php 73.39% <0%> (+4.43%) 84% <0%> (ø) ⬇️
app/Services/Clients/Client.php 86.66% <0%> (+26.66%) 15% <0%> (ø) ⬇️
app/Helpers/TorrentHelper.php 60% <0%> (+30%) 10% <0%> (ø) ⬇️
app/Services/Data/Movie.php 33.33% <0%> (+33.33%) 40% <0%> (ø) ⬇️
app/Services/Clients/TmdbClient.php 46.08% <0%> (+45.16%) 89% <0%> (ø) ⬇️
app/Services/Data/Genre.php 60% <0%> (+60%) 7% <0%> (ø) ⬇️
app/Services/MovieScrapper.php 83.33% <0%> (+66.66%) 10% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd166ff...f853b33. Read the comment docs.

@cbj4074
Copy link
Contributor Author

cbj4074 commented Mar 11, 2020

I can't easily test the front-end at the moment, but my recommendation is that we merge this, because it won't make the problem any worse, and could very well fix it.

@cbj4074 cbj4074 requested a review from HDVinnie March 11, 2020 15:54
@cbj4074 cbj4074 marked this pull request as ready for review March 11, 2020 15:55
@HDVinnie HDVinnie merged commit 8dbed58 into HDInnovations:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants