Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move calls to env() out of UsersTableSeeder #1202

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

cbj4074
Copy link
Contributor

@cbj4074 cbj4074 commented Mar 4, 2020

env() calls should be made only from within config files.

Note that the 'owner-username' is not prepended with 'default-' because,
unlike the other two values, it should not be changed after
installation, specifically because the account should always be
looked-up by username and not ID (despite existing code that currently
does the latter).

@cbj4074 cbj4074 force-pushed the controller-tests branch from da9c463 to 5aaa5ab Compare March 4, 2020 02:07
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #1202 into master will decrease coverage by 1.12%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1202      +/-   ##
============================================
- Coverage     25.66%   24.54%   -1.13%     
  Complexity     4140     4140              
============================================
  Files           296      296              
  Lines         13109    13109              
============================================
- Hits           3365     3217     -148     
- Misses         9744     9892     +148
Impacted Files Coverage Δ Complexity Δ
app/Http/Controllers/ContactController.php 0% <0%> (ø) 2 <0> (ø) ⬇️
app/Jobs/ProcessMassPM.php 0% <0%> (-100%) 2% <0%> (ø)
app/Services/Data/Person.php 0% <0%> (-87.5%) 7% <0%> (ø)
app/Services/Data/Genre.php 0% <0%> (-60%) 7% <0%> (ø)
app/Services/Clients/TmdbClient.php 5.52% <0%> (-51.16%) 89% <0%> (ø)
app/Services/Clients/Client.php 60% <0%> (-26.67%) 15% <0%> (ø)
app/Services/Data/Movie.php 17.46% <0%> (-14.29%) 40% <0%> (ø)
...pp/Http/Controllers/Staff/MassActionController.php 63.63% <0%> (-6.07%) 6% <0%> (ø)
app/Http/Controllers/API/TorrentController.php 65.67% <0%> (-2.49%) 83% <0%> (ø)
app/Models/User.php 36.11% <0%> (-1.2%) 122% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d478776...016f948. Read the comment docs.

env() calls should be made *only* from within config files.

Note that the 'owner-username' is not prepended with 'default-' because,
unlike the other two values, it should not be changed after
installation, specifically because the account should always be
looked-up by username and not ID (despite existing code that currently
does the latter).
@cbj4074 cbj4074 force-pushed the controller-tests branch from 5aaa5ab to 016f948 Compare March 4, 2020 02:26
@cbj4074 cbj4074 marked this pull request as ready for review March 4, 2020 02:42
@cbj4074 cbj4074 requested a review from HDVinnie March 4, 2020 02:44
@HDVinnie HDVinnie merged commit 2df0537 into HDInnovations:master Mar 4, 2020
@cbj4074 cbj4074 deleted the controller-tests branch March 4, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants