CMake: (fix) Szip / libaec filter #3035
Conversation
jwsblokland
commented
Jun 2, 2023
jwsblokland
commented
- Fixed the cmake configuration for the filter Szip / libaec. Now, the decoding of this filter is properly configured and included in the HDF5 library.
jwsblokland
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
hyoklee
added
Branch - 1.14
CMakeFilters.cmake
Outdated
| endif () | ||
| if (SZIP_FOUND) | ||
| set (H5_HAVE_FILTER_SZIP 1) | ||
| set (H5_HAVE_SZLIB_H 1) |
There was a problem hiding this comment.
Actually these first three set routines should be collated into the last if (SZIP_FOUND) block to have one source of these settings.
There was a problem hiding this comment.
Yes, that is a good idea. I forced pushed this modification.
Would it be possible to test szip/libaec compression via Github actions on a more structure level? In this case, it was a bit of luck I catch this issue while working on improving the current ROS3 implementation by switching on both the encoding and decoding functionality of th szip/libaec filter.
- Fixed the cmake configuration for the filter Szip / libaec. Now, the decoding of this filter is properly configured and included in the HDF5 library.
jwsblokland
force-pushed
the
bugfix/cmake_szip_libaec
branch
from
0a0a25c
to
6c6cb3e
Compare
|
Looks great! |
|
For consistency - would you mind moving/collating the similar three lines in the zlib code (see lines 94-96) |
- Improved the cmake configuration for the filter zlib.
Sure no problem. I have pushed the changes. I noticed that lines 113-115 could potentially be moved to the bottom if statement if we can assume that |
