Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 34 #154

Merged
merged 4 commits into from
Feb 23, 2024
Merged

SDK 34 #154

merged 4 commits into from
Feb 23, 2024

Conversation

Dhina17
Copy link
Contributor

@Dhina17 Dhina17 commented Jan 4, 2024

No description provided.

@Dhina17 Dhina17 force-pushed the master branch 3 times, most recently from 9696cd5 to 0bf692c Compare January 4, 2024 09:12
Needed for jitpack release.
@HBiSoft
Copy link
Owner

HBiSoft commented Jan 5, 2024

Thank you for the pull request. I will have a look and test it later today.

@jerinjohnk
Copy link

jerinjohnk commented Feb 1, 2024

After upgrading our targetSdkVersion to 34, HBRecorder has started crashing on Android 14.

#156 #157

@robrechtme
Copy link

Looks good to me, would be nice if this can get merged 🙂

@eliaslecomte
Copy link

Nice contribution @Dhina17!

I wonder if this is really how Android 14 intended us to use? What is the underlaying platform change that requires this? Could you link to the documentation?

Handler handler = new Handler(Looper.getMainLooper());
        mMediaProjection.registerCallback(new MediaProjection.Callback() {
            // Nothing
            // We don't use it but register it to avoid runtime error from SDK 34+.
        }, handler);

@mirjalal
Copy link

@HBiSoft when do you plan to merge these changes?

@HBiSoft HBiSoft merged commit f3bff6c into HBiSoft:master Feb 23, 2024
@HBiSoft
Copy link
Owner

HBiSoft commented Feb 24, 2024

@mirjalal
Merged and is available in 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants