Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix space character following username twice #52

Merged
merged 3 commits into from
May 27, 2023

Conversation

H4ppy-04
Copy link
Owner

  • fix space character
  • new function for parse-ing date object
  • derive author from href tag instead of by text value of navstring object

* created new date function

* `author_and_date` receives and formats date

* urlparse to get rid of issues when deriving author_name from href tag

Issue: #48

Authored-by: Joshua Rose <[email protected]>
@H4ppy-04 H4ppy-04 added the bug Something isn't working label May 27, 2023
@H4ppy-04 H4ppy-04 linked an issue May 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #52 (2480362) into main (7435f42) will increase coverage by 0.97%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   81.69%   82.66%   +0.97%     
==========================================
  Files           1        1              
  Lines         213      248      +35     
==========================================
+ Hits          174      205      +31     
- Misses         39       43       +4     
Impacted Files Coverage Δ
src/urban.py 82.66% <89.74%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@H4ppy-04 H4ppy-04 merged commit 2d6bbcf into main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space character follows username twice
1 participant