Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix characters parsing issue with urllib decode on word input #47

Conversation

H4ppy-04
Copy link
Owner

  • Add strip on parsed word

  • Add urllib decode function to parsed word

Authored-by: Joshua Rose [email protected]

* Add `strip` on parsed word

* Add urllib decode function to parsed word

Authored-by: Joshua Rose <[email protected]>
@H4ppy-04 H4ppy-04 added the bug Something isn't working label May 27, 2023
@H4ppy-04 H4ppy-04 linked an issue May 27, 2023 that may be closed by this pull request
@H4ppy-04 H4ppy-04 changed the title feat: urllib decode on word input fix characters parsing issue with urllib decode on word input May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #47 (84c9247) into main (b65a3cb) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   81.06%   81.69%   +0.62%     
==========================================
  Files           1        1              
  Lines         206      213       +7     
==========================================
+ Hits          167      174       +7     
  Misses         39       39              
Impacted Files Coverage Δ
src/urban.py 81.69% <100.00%> (+0.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Implements tests for word input decoder

Issue: #46
Pull Request: #47
Related commit: 3b6544e
Tag: 1.0.2

Authored-by: Joshua Rose <[email protected]>
@H4ppy-04 H4ppy-04 merged commit ed2f6a0 into main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbols typed manually will appear in formatted output string
1 participant