Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alb): alb not working when header value is not string #74

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

H4ad
Copy link
Owner

@H4ad H4ad commented Dec 20, 2022

Fixes CodeGenieApp/serverless-express#563

Description of change

Force all headers to be string when it returns to the cloud.

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Added documentation inside www/docs/main folder.
  • Included new files inside index.doc.ts.
  • The new commits follow conventions outlined in the conventional commit spec

@H4ad H4ad added the bug Something isn't working label Dec 20, 2022
@H4ad H4ad self-assigned this Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #74 (10d72ac) into main (6edb996) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          60       60           
  Lines        1275     1275           
  Branches      292      292           
=======================================
  Hits         1271     1271           
  Misses          4        4           
Impacted Files Coverage Δ
src/core/headers.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@H4ad H4ad merged commit 29b8320 into main Dec 20, 2022
@H4ad H4ad deleted the fix/alb-stringify-headers branch December 20, 2022 20:32
@github-actions
Copy link

🎉 This PR is included in version 2.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

express.static doesnt work with ALB endpoint
1 participant