Add partial bindings for plJPEG and plPNG.
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These bindings will be useful for Python programs that want to create mipmaps from JPEGs without round-tripping the image contents though another library (eg PIL) and getting the Hank Hill hot dog effect.
This is to match `plJPEG::DecompressJPEG()`. It's more useful for maintaining something like pngcrush compression when importing a PNG into a PRP.
zrax
reviewed
Dec 6, 2024
This required some work in plJPEG to not use libjpeg structs in the class itself. I took the opportunity to write some simple RAII helpers to simplify life.
zrax
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only included the two most immediately useful things in Python - loading JPEGs and PNGs from a stream into a
plMipmap.