Add missing functions to read PNGs and JPGs. #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason Mac homebrew's libjpeg-turbo is failing in the CI. I've checked my own install, and the version installed by homebrew has the necessary |
Hoikas
reviewed
Oct 23, 2022
Deledrius
force-pushed
the
image_functions
branch
3 times, most recently
from
615f2a9 to
e8db122
Compare
|
I've added the commit from #256 so that this PR can successfully build. |
Deledrius
force-pushed
the
image_functions
branch
from
e8db122 to
2a3d013
Compare
Hoikas
reviewed
Mar 5, 2024
Deledrius
force-pushed
the
image_functions
branch
2 times, most recently
from
6d4afad to
438ec7d
Compare
Apply suggestions from code review. Co-authored-by: Adam Johnson <[email protected]>
Apply suggestions from code review. Co-authored-by: Adam Johnson <[email protected]>
Apply suggestions from code review. Co-authored-by: Adam Johnson <[email protected]>
Apply suggestions from code review. Co-authored-by: Michael Hansen <[email protected]>
Apply suggestions from code review. Co-authored-by: Adam Johnson <[email protected]>
Deledrius
force-pushed
the
image_functions
branch
from
438ec7d to
b735289
Compare
|
This PR has been rebased onto master and review suggestions have been incorporated. |
zrax
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the previously-unimplemented JPEG writer, as well as two new functions to read PNG and JPG files directly into a plMipmap. The existing readers were intended to be used only when reading from a data stream where the size of the buffer is already known by the calling function, and as such are inconvenient when reading directly from a file.
Depends on #127.