Fix #1620

[Hoikas]

Fixes #1620 by avoiding a double-scale of mouse coordinates. I also included a bonus multi-monitor fix.

I hardwired the cursor to always think it's hovering over a player with the name It's a Spooky Ghost!...

On master:

With this PR:

For reference:

[dpogue]

I suspect this will need testing on macOS retina screens /cc @colincornaby

[colincornaby]

This change broke macOS. I'll dig into why. Just for background - why didn't this work on Windows?

[Hoikas]

WM_MOUSEMOVE and friends send coordinates that are already DPI aware, therefore there is no need to scale them. They are already scaled.

[colincornaby]

That explains it. The input system on macOS does not scale with DPI. Let me consider what to do (including possibly scaling the macOS input by hand) and I'll get back to you shortly.

[colincornaby]

Suggested change for macOS, in Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSView.mm

    NSRect windowViewBounds = self.bounds;
    CGFloat xNormal = (windowLocation.x) / windowViewBounds.size.width;
    CGFloat yNormal =
        (windowViewBounds.size.height - windowLocation.y) / windowViewBounds.size.height;

    plIMouseXEventMsg* pXMsg = new plIMouseXEventMsg;
    plIMouseYEventMsg* pYMsg = new plIMouseYEventMsg;
    
    pXMsg->fX = xNormal;
    pYMsg->fY = yNormal;
    
    // Plasma internally uses input coords as display coords
    pXMsg->fWx = viewLocation.x * self.window.screen.backingScaleFactor;
    pYMsg->fWy = (windowViewBounds.size.height - windowLocation.y) * self.window.screen.backingScaleFactor;

    @synchronized(self.layer) {
        if (self.inputManager) {
            self.inputManager->MsgReceive(pXMsg);
            self.inputManager->MsgReceive(pYMsg);
        }
    }

[Hoikas]

@colincornaby I've pushed your change and an additional two to ensure that scaled coordinates are going down when the mouse is being recentered. I've verified that the code compiles, but the client login window doesn't actually seem to appear on my system. Maybe this is just a problem with my setup or an unrelated regression, but I'd appreciate your taking a glance at things.

[colincornaby]

I am seeing the login window. Weird.

I've seen the login window not appear when the client can't connect to the game server (it just gets stuck in a retry loop, might be its own bug.) When the login window doesn't appear you could try pausing in the debugger to see where it is stuck.

Otherwise, this change looks good on my machine.

[Hoikas]

Great! I'm going to wait for a green checkmark before merging, though ;)

…

Message ID: ***@***.***>