Fix #1617. #1619
Merged
Fix #1617. #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This invalidates the UI when the clothing material combo box selections are changed. By invalidating the UI, the texture pickers update appropriately. I also added some extra safety valves to reduce spurious updates that the debugger showed coming through.
dpogue
approved these changes
Oct 12, 2024
|
It seems to fix the problem for me in Max 2022. I'm a little unsure as to why this is needed though - it feels like the code should have simply worked as is. I wonder if this was a problem in Max 7? |
|
That makes me wonder about regressions on Max 7. It doesn't look like it should be a problem, but it wouldn't be the first time that a seemingly-innocuous change around the WinAPI breaks something in older Max versions. |
|
This isn't actually a WinAPI regression. What's happening here is that, in Max 2022, the |
|
Built and tested this and it's working in Max 2022 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1617.
This invalidates the UI when the clothing material combo box selections are changed. By invalidating the UI, the texture pickers update appropriately. I also added some extra safety valves to reduce spurious updates that the debugger showed coming through.