Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups to the hsRAMStream test #1592

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Cleanups to the hsRAMStream test #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Sources/Tests/CoreTests/test_RAMStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,30 @@ You can contact Cyan Worlds, Inc. by email [email protected]
*==LICENSE==*/

#include <gtest/gtest.h>
#include <string_view>

#include "hsStream.h"

/**
* This tests that the hsRAMStream buffer is properly initialized and resized
* upon initial writing, ensuring that we don't hit any assertions around
* mempy'ing to a null buffer.
*/
TEST(hsRAMStream, initializeBufferOnFirstWrite)
{
const char* str = "hsRAMStream initializeBufferOnFirstWrite";
constexpr std::string_view str = "hsRAMStream initializeBufferOnFirstWrite";
hsRAMStream s;

// Initial write to the buffer should initialize and resize it
s.WriteSafeString(str);
EXPECT_EQ(s.GetPosition(), strlen(str) + 2);
EXPECT_EQ(s.GetPosition(), str.size() + 2);

// Writing more should cause it to resize further
s.WriteLE32(1);
EXPECT_EQ(s.GetPosition(), strlen(str) + 2 + 4);
EXPECT_EQ(s.GetPosition(), str.size() + 2 + 4);

// Going back and rewriting over existing data should memcpy without resize
s.Skip(-4);
s.WriteLE32(5);
EXPECT_EQ(s.GetPosition(), strlen(str) + 2 + 4);
EXPECT_EQ(s.GetPosition(), str.size() + 2 + 4);
}
Loading