Enable macOS arm64 builds in CI #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
approved these changes
Nov 4, 2023
Hoikas
requested changes
Nov 5, 2023
| @@ -59,7 +59,7 @@ if(_PythonFinder_WantLibs) | |||
| find_program( | |||
| @PythonFinder_PREFIX@_EXECUTABLE | |||
| NAMES "python" "python@PYTHON_VERSION_MAJOR@.@PYTHON_VERSION_MINOR@" | |||
| PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/tools/python3" | |||
| PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_HOST_TRIPLET}/tools/python3" | |||
There was a problem hiding this comment.
Actually, now that I'm thinking about it... We need to bump the port-version in vcpkg.json to ensure that this gets deployed.
Hoikas
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires using the host platform's Python interpreter rather than the target platform's interpreter, which runs as part of the build process for resource.dat generation.
Also have to disable running tests when cross-compiling because the host system can't run the test executables compiled for the target system.