Move most pnUtils code into more appropriate places #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Oct 21, 2023
CoreLib is where I had begrudgingly settled on Part of me would like to see plEncryption turned into something more like plRC4Encryption (and clean it up a bit to removed the unimplemented RSA code and maybe turn it into a class instance), but that could be work for another PR. |
This uncovered a missing dependency and include in plNetClientComm.
This uncovered a missing dependency and include in pnNetProtocol.
dgelessus
force-pushed
the
reduce_pnutils
branch
from
cd39b70 to
a1ae126
Compare
Hoikas
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnUtils is a pretty random mix of unrelated things. This PR cleans things up a bit by moving code to more appropriate places (plEncryption.h/.cpp into pnEncryption) and removing duplicate APIs (
TimeGetMsreplaced byhsTimer::GetMilliSeconds).The only thing left in pnUtils now is the UTF-16
StrCopy. I left that where it is for now, because it's not trivial to replace withST::stringor standard C++ APIs and it's still used in a couple of different places. (I could move it into CoreLib, but I don't want more weird string functions implicitly pulled in everywhere...)